From: Ben Greear <greearb@candelatech.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
lrodriguez@atheros.com
Subject: Re: [PATCH 1/4] ath9k: fix bogus sequence number increases on aggregation tid flush
Date: Mon, 10 Jan 2011 20:39:42 -0800 [thread overview]
Message-ID: <4D2BDF0E.8000808@candelatech.com> (raw)
In-Reply-To: <1294704350-50621-1-git-send-email-nbd@openwrt.org>
On 01/10/2011 04:05 PM, Felix Fietkau wrote:
> When a tid pointer is passed to ath_tx_send_normal(), it increases the
> starting sequence number for the next AMPDU action frame, which should
> only be done if the sequence number assignment is fresh. In this case
> it is clearly not.
I added these to my system. It doesn't seem any worse, but I'm
still seeing my tx-hang logic kick off, so at least some of the
pending queue stuff still has issues I think:
ath: txq: ec731e78 axq_qnum: 2, mac80211_qnum: 2 axq_link: (null) pending frames: 73 axq_acq empty: 0 stopped: 0 axq_depth: 0 Attempting to restart tx logic.
In general though, my testing is finally starting to surprise with good results
instead of bugs, so I'm quite optimistic these days!
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2011-01-11 4:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 0:05 [PATCH 1/4] ath9k: fix bogus sequence number increases on aggregation tid flush Felix Fietkau
2011-01-11 0:05 ` [PATCH 2/4] ath9k: fix initial sequence number after starting an ampdu session Felix Fietkau
2011-01-11 0:05 ` [PATCH 3/4] ath9k: reinitialize block ack window data when starting aggregation Felix Fietkau
2011-01-11 0:05 ` [PATCH 4/4] ath9k: reduce the likelihood of baseband hang check false positives Felix Fietkau
2011-01-11 4:39 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2BDF0E.8000808@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).