Re: [RFC v3] mac80211: Optimize scans on current operating channel.

[Ben Greear <greearb@candelatech.com>]

On 01/27/2011 05:52 AM, Johannes Berg wrote:

>> @@ -396,10 +397,14 @@ ieee80211_rx_h_passive_scan(struct ieee80211_rx_data *rx)
>>   		return ieee80211_scan_rx(rx->sdata, skb);
>>
>>   	if (test_bit(SCAN_SW_SCANNING,&local->scanning)) {
>> -		/* drop all the other packets during a software scan anyway */
>> -		if (ieee80211_scan_rx(rx->sdata, skb) != RX_QUEUED)
>> +		ret = ieee80211_scan_rx(rx->sdata, skb);
>> +		/* drop all the other packets while scanning off channel */
>> +		if (ret != RX_QUEUED&&
>> +		    test_bit(SCAN_OFF_CHANNEL,&local->scanning)) {
>>   			dev_kfree_skb(skb);
>> -		return RX_QUEUED;
>> +			return RX_QUEUED;
>> +		}
>> +		return ret;
>
> Alright -- but does the mlme.c code know not to expect beacons during an
> on-channel scan?

I have a more basic question on this:

Should we just pass all packets on up the stack, regardless of whether we are
offchannel or not?  I think that would simplify things here,
and if/when we ever support things other than just scanning on
different off-channels, that code would just work.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com