linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Why is wmm_param required for HT40- in mlme.c
Date: Sun, 30 Jan 2011 09:34:32 -0800	[thread overview]
Message-ID: <4D45A128.6060905@candelatech.com> (raw)
In-Reply-To: <1296380208.3616.0.camel@jlt3.sipsolutions.net>

On 01/30/2011 01:36 AM, Johannes Berg wrote:
> On Sat, 2011-01-29 at 21:38 -0800, Ben Greear wrote:
>> I tried to set up hostapd to do HT40-, but for whatever reason,
>> it's not sending any wmm_param options, so the stations will not
>> associate with HT40- enabled due to the check below.
>>
>> Is it really *reqired* that wmm_param exist to enable HT mode?
>>
>>   From mlme.c:
>> 	if (elems.ht_info_elem&&  elems.wmm_param&&
>> 	(sdata->local->hw.queues>= 4)&&
>> 	!(ifmgd->flags&  IEEE80211_STA_DISABLE_11N))
>> 		changed |= ieee80211_enable_ht(sdata, elems.ht_info_elem,
>> 					       cbss->bssid, ap_ht_cap_flags);
>
> 802.11n-2009 says it is required.

Do you know the pertinent section, or some keywords to search for?  I'm
unable to find anything useful.

Also, from looking at utils.c, it seems that this wmm_param is
a vendor specific Microsoft thing?  I don't see anywhere else that
wmm_param is assigned...

		case WLAN_EID_VENDOR_SPECIFIC:
			if (elen >= 4 && pos[0] == 0x00 && pos[1] == 0x50 &&
			    pos[2] == 0xf2) {
				/* Microsoft OUI (00:50:F2) */

				if (calc_crc)
					crc = crc32_be(crc, pos - 2, elen + 2);

				if (pos[3] == 1) {
					/* OUI Type 1 - WPA IE */
					elems->wpa = pos;
					elems->wpa_len = elen;
				} else if (elen >= 5 && pos[3] == 2) {
					/* OUI Type 2 - WMM IE */
					if (pos[4] == 0) {
						elems->wmm_info = pos;
						elems->wmm_info_len = elen;
					} else if (pos[4] == 1) {
						elems->wmm_param = pos;
						elems->wmm_param_len = elen;
					}
				}
			}
			break;

Thanks,
Ben

>
> johannes


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2011-01-30 17:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-30  5:38 Why is wmm_param required for HT40- in mlme.c Ben Greear
2011-01-30  9:36 ` Johannes Berg
2011-01-30 17:34   ` Ben Greear [this message]
2011-01-31 11:03     ` Johannes Berg
2011-01-31 17:35       ` Ben Greear
2011-01-31 17:40         ` Johannes Berg
2011-01-30 17:41   ` Pat Erley
2011-01-31 11:28     ` Jouni Malinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D45A128.6060905@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).