* [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection [not found] <4D45A583.3060605@davizone.at> @ 2011-01-30 19:10 ` David Gnedt 2011-01-31 15:08 ` Kalle Valo 2011-02-02 22:41 ` Grazvydas Ignotas 0 siblings, 2 replies; 6+ messages in thread From: David Gnedt @ 2011-01-30 19:10 UTC (permalink / raw) To: John W. Linville Cc: linux-wireless, Kalle Valo, Grazvydas Ignotas, Denis 'GNUtoo' Carikli Patch 01-03 fix some bugs. Patch 04-09 contain some feature ports from Maemo Fremantle and wl1271. Patch 10-18 implement (mainly) monitor mode and packet injection. Sorry for the partly broken patches, I thought I configured my client the right way. I tried to stop the mails at my mailserver, but it was mostly already too late. David Gnedt (18): wl1251: fix queue stopping/waking for TX path wl1251: fix 4-byte TX buffer alignment wl1251: fix scan behaviour while not associated wl1251: add sysfs interface for bluetooth coexistence mode configuration wl1251: retry power save entry wl1251: enable beacon early termination while in power-saving mode wl1251: implement connection quality monitoring wl1251: implement hardware ARP filtering wl1251: enable adhoc mode wl1251: split RX and TX data path initialisation wl1251: configure hardware en-/decryption for monitor mode wl1251: set rate index and preamble flag on received packets wl1251: rework configure_filter() callback wl1251: implement multicast address filtering wl1251: disable power saving in monitor mode wl1251: fix channel switching in monitor mode wl1251: enable tx path in monitor mode if necessary for packet injection wl1251: disable retry and ACK policy for injected packets drivers/net/wireless/wl1251/acx.c | 150 ++++++++++++++-- drivers/net/wireless/wl1251/acx.h | 106 ++++++++++- drivers/net/wireless/wl1251/boot.c | 3 +- drivers/net/wireless/wl1251/cmd.c | 58 ++++-- drivers/net/wireless/wl1251/cmd.h | 8 +- drivers/net/wireless/wl1251/event.c | 62 ++++++ drivers/net/wireless/wl1251/event.h | 7 + drivers/net/wireless/wl1251/init.c | 19 +- drivers/net/wireless/wl1251/main.c | 348 ++++++++++++++++++++++++++++------ drivers/net/wireless/wl1251/ps.c | 11 + drivers/net/wireless/wl1251/rx.c | 48 +++++- drivers/net/wireless/wl1251/tx.c | 101 ++++++---- drivers/net/wireless/wl1251/wl1251.h | 26 ++- 13 files changed, 795 insertions(+), 152 deletions(-) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection 2011-01-30 19:10 ` [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection David Gnedt @ 2011-01-31 15:08 ` Kalle Valo 2011-01-31 22:57 ` David Gnedt 2011-02-02 11:01 ` Grazvydas Ignotas 2011-02-02 22:41 ` Grazvydas Ignotas 1 sibling, 2 replies; 6+ messages in thread From: Kalle Valo @ 2011-01-31 15:08 UTC (permalink / raw) To: David Gnedt Cc: John W. Linville, linux-wireless, Grazvydas Ignotas, Denis 'GNUtoo' Carikli Hi David, David Gnedt <david.gnedt@davizone.at> writes: > Patch 01-03 fix some bugs. > Patch 04-09 contain some feature ports from Maemo Fremantle and wl1271. > Patch 10-18 implement (mainly) monitor mode and packet injection. How did you test the patches? For example, what hardware did you use etc. About the code from fremantle kernels. Few weeks ago nokia sent me privately the original patches from their internal git tree, I gave some comments and never heard back. So, in theory I should have all the fremantle patches somewhere in my email archives. I would just need to clean them up and send them here. I'll go over your patches and let's see what we should do. > Sorry for the partly broken patches, I thought I configured my client the > right way. I tried to stop the mails at my mailserver, but it was mostly > already too late. No problem. But whenever you resend your patchset, please add a revision to them, otherwise it's impossible to know which patch is which. Good way is to use tag "[PATCH v2]" or similar. -- Kalle Valo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection 2011-01-31 15:08 ` Kalle Valo @ 2011-01-31 22:57 ` David Gnedt 2011-02-01 6:39 ` Kalle Valo 2011-02-02 11:01 ` Grazvydas Ignotas 1 sibling, 1 reply; 6+ messages in thread From: David Gnedt @ 2011-01-31 22:57 UTC (permalink / raw) To: Kalle Valo Cc: John W. Linville, linux-wireless, Grazvydas Ignotas, Denis 'GNUtoo' Carikli Am 2011-01-31 16:08, schrieb Kalle Valo: > How did you test the patches? For example, what hardware did you use > etc. I tested the patches with compat-wireless and a modified fremantle 2.6.28 kernel on my Nokia N900. > About the code from fremantle kernels. Few weeks ago nokia sent me > privately the original patches from their internal git tree, I gave > some comments and never heard back. So, in theory I should have all > the fremantle patches somewhere in my email archives. I would just > need to clean them up and send them here. I'll go over your patches > and let's see what we should do. It would be interesting if I missed some features. I diffed the drivers, but I am not 100% sure if I overlooked something useful. One thing I haven't included in this patchset is the netlink interface from the fremantle code for NVS loading because I thought it wouldn't be accepted anyway. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection 2011-01-31 22:57 ` David Gnedt @ 2011-02-01 6:39 ` Kalle Valo 0 siblings, 0 replies; 6+ messages in thread From: Kalle Valo @ 2011-02-01 6:39 UTC (permalink / raw) To: David Gnedt Cc: John W. Linville, linux-wireless, Grazvydas Ignotas, Denis 'GNUtoo' Carikli David Gnedt <david.gnedt@davizone.at> writes: > One thing I haven't included in this patchset is the netlink > interface from the fremantle code for NVS loading because I thought > it wouldn't be accepted anyway. Correct, it's definitely not for upstream. nl80211 now has testmode interface which can be used for that, but as wl1251 hardware is so old already I doubt anyone has any interest on. I have now read and commented some of your patches, I will go through the rest today. But 18 patches in a patchset is quite a lot. To make it easier to review and manage the patches I would recommend to split them to smaller and logical patchsets. -- Kalle Valo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection 2011-01-31 15:08 ` Kalle Valo 2011-01-31 22:57 ` David Gnedt @ 2011-02-02 11:01 ` Grazvydas Ignotas 1 sibling, 0 replies; 6+ messages in thread From: Grazvydas Ignotas @ 2011-02-02 11:01 UTC (permalink / raw) To: Kalle Valo Cc: David Gnedt, John W. Linville, linux-wireless, Denis 'GNUtoo' Carikli, Yuri Ershov, Luciano Coelho Hi, On Mon, Jan 31, 2011 at 5:08 PM, Kalle Valo <kvalo@adurom.com> wrote: > Hi David, > > David Gnedt <david.gnedt@davizone.at> writes: > >> Patch 01-03 fix some bugs. >> Patch 04-09 contain some feature ports from Maemo Fremantle and wl1271. >> Patch 10-18 implement (mainly) monitor mode and packet injection. > > How did you test the patches? For example, what hardware did you use > etc. > > About the code from fremantle kernels. Few weeks ago nokia sent me > privately the original patches from their internal git tree, I gave > some comments and never heard back. So, in theory I should have all > the fremantle patches somewhere in my email archives. I would just > need to clean them up and send them here. I'll go over your patches > and let's see what we should do. I was the one trying to organize this, Luciano managed this from Nokia side and Yuri (CCed) did the porting to newer kernels. However several patches were missing attribution and things somehow got stuck there. As for this series, I'll try to test them on pandora hardware over this week. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection 2011-01-30 19:10 ` [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection David Gnedt 2011-01-31 15:08 ` Kalle Valo @ 2011-02-02 22:41 ` Grazvydas Ignotas 1 sibling, 0 replies; 6+ messages in thread From: Grazvydas Ignotas @ 2011-02-02 22:41 UTC (permalink / raw) To: David Gnedt Cc: John W. Linville, linux-wireless, Kalle Valo, Denis 'GNUtoo' Carikli On Sun, Jan 30, 2011 at 9:10 PM, David Gnedt <david.gnedt@davizone.at> wrote: > Patch 01-03 fix some bugs. > Patch 04-09 contain some feature ports from Maemo Fremantle and wl1271. > Patch 10-18 implement (mainly) monitor mode and packet injection. Just tried this on pandora board with 2.6.37 kernel and everything seems to be fine. Haven't tested monitor mode or packet injection though, so for fixes and feature ports: Tested-by: Grazvydas Ignotas <notasas@gmail.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-02 22:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4D45A583.3060605@davizone.at>
2011-01-30 19:10 ` [PATCH 00/18] wl1251: feature ports / monitor mode / packet injection David Gnedt
2011-01-31 15:08 ` Kalle Valo
2011-01-31 22:57 ` David Gnedt
2011-02-01 6:39 ` Kalle Valo
2011-02-02 11:01 ` Grazvydas Ignotas
2011-02-02 22:41 ` Grazvydas Ignotas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).