* Missing config_hw() in ieee80211_ibss_join?
@ 2011-01-31 18:29 Ben Greear
2011-01-31 18:43 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Ben Greear @ 2011-01-31 18:29 UTC (permalink / raw)
To: linux-wireless
The method ieee80211_ibss_join can change the operating channel,
but I don't see anywhere that it calls config_hw to flush the
changes into the kernel.
Should we add such a call?
This was found by code inspection...I didn't actually try using
this code...
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Missing config_hw() in ieee80211_ibss_join?
2011-01-31 18:29 Missing config_hw() in ieee80211_ibss_join? Ben Greear
@ 2011-01-31 18:43 ` Johannes Berg
2011-01-31 18:45 ` Ben Greear
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2011-01-31 18:43 UTC (permalink / raw)
To: Ben Greear; +Cc: linux-wireless
On Mon, 2011-01-31 at 10:29 -0800, Ben Greear wrote:
> The method ieee80211_ibss_join can change the operating channel,
> but I don't see anywhere that it calls config_hw to flush the
> changes into the kernel.
>
> Should we add such a call?
I don't think so -- it doesn't actually really join until it has scanned
first etc.?
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Missing config_hw() in ieee80211_ibss_join?
2011-01-31 18:43 ` Johannes Berg
@ 2011-01-31 18:45 ` Ben Greear
0 siblings, 0 replies; 3+ messages in thread
From: Ben Greear @ 2011-01-31 18:45 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
On 01/31/2011 10:43 AM, Johannes Berg wrote:
> On Mon, 2011-01-31 at 10:29 -0800, Ben Greear wrote:
>> The method ieee80211_ibss_join can change the operating channel,
>> but I don't see anywhere that it calls config_hw to flush the
>> changes into the kernel.
>>
>> Should we add such a call?
>
> I don't think so -- it doesn't actually really join until it has scanned
> first etc.?
Ok, good enough for me. I don't think this will cause any problems
with my scan-on-channel logic, but it looked a bit strange while
I was auditing the oper-channel related code.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-31 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-31 18:29 Missing config_hw() in ieee80211_ibss_join? Ben Greear
2011-01-31 18:43 ` Johannes Berg
2011-01-31 18:45 ` Ben Greear
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).