From: David Gnedt <david.gnedt@davizone.at>
To: Kalle Valo <kvalo@adurom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Grazvydas Ignotas <notasas@gmail.com>,
Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Subject: Re: [PATCH 17/18] wl1251: enable tx path in monitor mode if necessary for packet injection
Date: Tue, 01 Feb 2011 00:00:38 +0100 [thread overview]
Message-ID: <4D473F16.4010102@davizone.at> (raw)
In-Reply-To: <8762t5dptt.fsf@purkki.adurom.net>
Am 2011-01-31 17:02, schrieb Kalle Valo:
> David Gnedt <david.gnedt@davizone.at> writes:
>
>> If necessary enable the tx path in monitor mode for packet injection using
>> the JOIN command with BSS_TYPE_STA_BSS and zero BSSID.
>
> Ok, this answers my question, you send TX_ENABLE command during the
> first frame transmission. I have to admit that it sounds a bit
> hackish. I would prefer to keep the driver as simple as possible,
> makes it easier to maintain it that way.
>
> I would like to step back and first look at the problem you are trying
> to solve and maybe there's a way we can fix the join command. Was it
> something to do with firmware sending extra frames? Unfortunately TI
> firmwares are notorious for that.
Yeah, you are right, but I don't think the JOIN command can be fixed. Even if we
use it with a zero BSSID and zero SSID, it sends some frames. Then there are not
much parameters left, which can influence it's behaviour.
All in all I think the JOIN command was only meant to be used when you really
want to associate.
It would be really unpleasant if the firmware keeps sending frames while channel
hopping (through user-space software) in monitor mode.
That's why I use RX_ENABLE to switch channels in monitor mode, but that again
results in a disabled TX path. My testing showed that it also can't be enabled
again with TX_ENABLE, only a JOIN command enables the TX path again.
By the way, I only split up RX_ENABLE and TX_ENABLE to reduce the amount of
firmware commands sent.
So summing up, I think the JOIN command is the only command which enables the TX
path, but with the drawback of also transmitting some extra frames.
Nevertheless I am going to experiment with the JOIN command again, maybe I have
overlooked something.
next prev parent reply other threads:[~2011-01-31 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D45A79A.1030102@davizone.at>
2011-01-30 19:11 ` [PATCH 17/18] wl1251: enable tx path in monitor mode if necessary for packet injection David Gnedt
2011-01-31 16:02 ` Kalle Valo
2011-01-31 23:00 ` David Gnedt [this message]
2011-02-01 22:47 ` Kalle Valo
2011-02-18 21:01 ` David Gnedt
2011-03-08 7:39 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D473F16.4010102@davizone.at \
--to=david.gnedt@davizone.at \
--cc=GNUtoo@no-log.org \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).