Re: [PATCH] ath9k: Fix memory leak due to failed PAPRD frames

[Mohammed Shafi <mshajakhan@atheros.com>]

On Tuesday 01 February 2011 07:35 PM, John W. Linville wrote:
> On Tue, Feb 01, 2011 at 10:11:54AM +0530, Mohammed Shafi wrote:
>    
>> On Tuesday 01 February 2011 12:13 AM, Luis R. Rodriguez wrote:
>>      
>>> On Sun, Jan 30, 2011 at 11:55 PM, Mohammed Shafi Shajakhan
>>> <mshajakhan@atheros.com>   wrote:
>>>        
>>>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>>>
>>>> free the skb's when the Tx of PAPRD frames fails and also add a debug
>>>> message indicating that.
>>>>
>>>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>>>          
>>> Is this a stable fix?
>>>        
>> No Luis, this problem came from some recent changes in PAPRD before
>> that it was Ok.
>>      
> The patch applied to wireless-2.6 without changes, and the error
> handling for ath_tx_start matched existing usage.  So, I have it
> queued now in wireless-2.6 with an added "Cc: stable@kernel.org".
>
> Should I not?
>    
John this will be applicable for only 2.6.38 stable kernel.
The issue fixes for 2.6.37-rc5+  and this problem is not handled in the 
following commit id:

commit 7607cbe2ad6931400c5d15ced342ab329ab8f92c
Date:   Mon Dec 13 08:40:52 2010 +0100

This will not be even applicable for 2.6.37. It will introduce a 
regression of double freeing skb's.

thanks,
shafi


> John
>