Re: [PATCH v9] mac80211: Optimize scans on current operating channel.

[Ben Greear <greearb@candelatech.com>]

On 02/02/2011 10:55 AM, Johannes Berg wrote:
> On Wed, 2011-02-02 at 10:18 -0800, greearb@candelatech.com wrote:
>
>> * Do no blindly go off/on channel in work.c  Instead, only call
>>    appropriate on/off code when we really need to change channels.
>
> Based on the powersave comments I had earlier, maybe we should remove
> that bit for now? Work items here require powersave is disabled, but we
> won't do that right now if we're on the same channel.
>
> Scan, on the other hand, will still disable powersave (right?)

With regard to scanning and power-save:  If we are scanning on
channel, I think we should still be able to receive normal traffic.

The offchannel_ps_enable has this comment:

/*
  * inform AP that we will go to sleep so that it will buffer the frames
  * while we scan
  */
static void ieee80211_offchannel_ps_enable(struct ieee80211_sub_if_data *sdata)


So, do we really need to call this method for on-channel scanning?

My naive assumption is that we would actually want the NIC to disable it's
local power-save logic while we are scanning so that it doesn't
get sleepy and miss beacons?

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com