From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@adurom.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/7] mac80211: Make STA disconnect messages warn instead of debug.
Date: Wed, 09 Feb 2011 06:26:19 -0800 [thread overview]
Message-ID: <4D52A40B.8020302@candelatech.com> (raw)
In-Reply-To: <87tygd76nw.fsf@purkki.adurom.net>
On 02/09/2011 04:07 AM, Kalle Valo wrote:
> Ben Greear<greearb@candelatech.com> writes:
>
>>> Messages like these are in the category "business as usual", which
>>> happens frequently when the device is moved. IMHO they are not really
>>> warnings. I'm worried that making the messages more visible might
>>> scare the users too much.
>>
>> To me it seems more useful than the network up/down messages that
>> are already printed from the networking core.
>
> You are not a normal user :) But what networking core messages are you
> referring to? I don't recall seeing anything like that.
ADDRCONF(NETDEV_CHANGE): sta6: link becomes ready
ADDRCONF(NETDEV_CHANGE): sta5: link becomes ready
ADDRCONF(NETDEV_CHANGE): sta4: link becomes ready
Possibly I previously hacked on the console logging levels and forgot
about it...
>
>> That said, I don't feel strongly about this change, and it's certainly
>> an easy patch for me to carry in my own tree.
>
> I also don't have any strong opinion about this, just voiced my
> concern.
No problem. One final note: These will only show if someone has
compiled in wireless debugging...
We can let the maintainer make the call :)
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-02-09 14:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 21:44 [PATCH 1/7] mac80211: Make STA disconnect messages warn instead of debug greearb
2011-02-07 21:44 ` [PATCH 2/7] ath9k: Print channel-type in chan-change dbg message greearb
2011-02-07 21:44 ` [PATCH 3/7] mac80211: Properly set work-item channel-type greearb
2011-02-14 10:21 ` Johannes Berg
2011-02-07 21:44 ` [PATCH 4/7] mac80211: Allow scanning on existing channel-type greearb
2011-02-07 21:44 ` [PATCH 5/7] mac80211: Allow work items to use existing channel type greearb
2011-02-07 21:44 ` [PATCH 6/7] ath9k: Add debug info for configuring power level greearb
2011-02-07 21:44 ` [PATCH 7/7] mac80211: Ensure power-level set properly for scanning greearb
2011-02-08 14:04 ` [PATCH 1/7] mac80211: Make STA disconnect messages warn instead of debug Kalle Valo
2011-02-08 17:10 ` Ben Greear
2011-02-09 12:07 ` Kalle Valo
2011-02-09 14:26 ` Ben Greear [this message]
2011-02-14 10:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D52A40B.8020302@candelatech.com \
--to=greearb@candelatech.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).