From: "Richard Schütz" <r.schtz@t-online.de>
To: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
lrodriguez@atheros.com
Subject: Re: [RFC] ath9k: Fix ath9k prevents CPU to enter C3 states
Date: Wed, 09 Feb 2011 17:48:10 +0100 [thread overview]
Message-ID: <4D52C54A.2010709@t-online.de> (raw)
In-Reply-To: <1297262007-15128-1-git-send-email-mshajakhan@atheros.com>
> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>
> The DMA latency issue is observed only in Intel pinetrail platforms but
> in the driver we had a default PM-QOS value of 55. This caused
> unnecessary power consumption and battery drain in other platforms.
> Address this issue by disabling PM-QOS by default by setting it's value
> as '0' and making code changes appropriately.This addresses the bug:
> https://bugzilla.kernel.org/show_bug.cgi?id=27532
> If the user sees some DMA latency issue he can still use the pmqos as a
> module parameter to trade power for throughput as below:
> sudo modprobe ath9k pmqos=55
>
> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
Acked-By: Richard Schütz <r.schtz@t-online.de>
Looks good to me with the exception of ATH9K_PM_QOS_DEFAULT_VALUE. But
John already mentioned that.
--
Regards,
Richard Schütz
next prev parent reply other threads:[~2011-02-09 16:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 14:33 [RFC] ath9k: Fix ath9k prevents CPU to enter C3 states Mohammed Shafi Shajakhan
2011-02-09 14:42 ` John W. Linville
2011-02-09 14:50 ` Mohammed Shafi
2011-02-09 16:48 ` Richard Schütz [this message]
2011-02-10 14:19 ` Mohammed Shafi
2011-02-10 17:41 ` Luis R. Rodriguez
2011-02-10 17:44 ` Richard Schütz
2011-02-11 13:31 ` Richard Schütz
2011-02-09 19:58 ` Luis R. Rodriguez
2011-02-10 14:18 ` Mohammed Shafi
-- strict thread matches above, loose matches on Subject: below --
2011-02-15 15:59 Mohammed Shafi Shajakhan
2011-02-15 16:12 ` John W. Linville
2011-02-16 5:05 ` Mohammed Shafi
2011-03-04 6:06 ` Mohammed Shafi
2011-03-04 13:37 ` John W. Linville
2011-03-04 14:26 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D52C54A.2010709@t-online.de \
--to=r.schtz@t-online.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=mshajakhan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).