From: Mohammed Shafi <mshajakhan@atheros.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
Mohammed Shajakhan <Mohammed.Shajakhan@Atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH] ath9k: make use of slot time macros
Date: Mon, 14 Feb 2011 10:05:27 +0530 [thread overview]
Message-ID: <4D58B10F.60907@atheros.com> (raw)
In-Reply-To: <20110211161551.GA2224@tuxdriver.com>
On Friday 11 February 2011 09:45 PM, John W. Linville wrote:
> On Fri, Feb 11, 2011 at 01:52:23PM +0100, Felix Fietkau wrote:
>
>> On 2011-02-11 8:01 AM, Mohammed Shafi Shajakhan wrote:
>>
>>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>>
>>> Instead of using raw numbers to assign slot time it would be better to
>>> make use of predefined slot time macros
>>>
>> How does this make it better?
>>
> Maybe if it was ATH9K_SHORT_SLOT_TIME it would make more sense?
>
John I never thought of that, but we have three macros in the driver :
mac.h 72 #define ATH9K_SLOT_TIME_6 6
mac.h 73 #define ATH9K_SLOT_TIME_9 9
mac.h 74 #define ATH9K_SLOT_TIME_20 20
both slot times 6,9 can be classified as short
thanks,
shafi
next prev parent reply other threads:[~2011-02-14 4:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 7:01 [PATCH] ath9k: make use of slot time macros Mohammed Shafi Shajakhan
2011-02-11 12:52 ` Felix Fietkau
2011-02-11 16:15 ` John W. Linville
2011-02-11 16:21 ` Felix Fietkau
2011-02-11 16:29 ` John W. Linville
2011-02-14 4:41 ` Mohammed Shafi
2011-02-14 4:46 ` Mohammed Shafi
2011-02-14 13:48 ` Felix Fietkau
2011-02-14 14:02 ` Mohammed Shafi
2011-02-14 14:29 ` Felix Fietkau
2011-02-14 14:36 ` Mohammed Shafi
2011-02-14 20:14 ` John W. Linville
2011-02-15 6:07 ` Mohammed Shafi
2011-02-14 4:35 ` Mohammed Shafi [this message]
2011-02-14 4:31 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D58B10F.60907@atheros.com \
--to=mshajakhan@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Mohammed.Shajakhan@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).