Re: Review of moving all DFS parameters to userspace

[Felix Fietkau <nbd@openwrt.org>]

On 2011-02-15 1:48 AM, Luis R. Rodriguez wrote:
> On Mon, Feb 14, 2011 at 7:39 AM, Zefir Kurtisi
> <zefir.kurtisi@neratec.com> wrote:
>> On 02/01/2011 06:32 PM, John W. Linville wrote:
>>> On Tue, Feb 01, 2011 at 08:38:05AM -0800, Luis R. Rodriguez wrote:
>>>> I though we had reviewed the possibility of moving DFS parameters to
>>>> userspace but it seems that's not the case. We now at least know we
>>>> can keep the DFS regions: US, JP, ETSI, the next step is to determine
>>>> if the DFS parameters for these regions will come from userspace or
>>>> kernelspace. I'm inclined to support starting off with moving this to
>>>> kernelspace just to let us move forward with this support, and once in
>>>> kernel, review the possibility to move this out to userspace.
>>>>
>>>> Thoughts?
>>>
>>> Seems like a reasonable approach for the short term...better than
>>> locking-in userland ABI...
>>>
>>> John
>>
>> Sorry, I was not aware that the userspace DFS approach was already discussed
>> and rejected.
> 
> 19:14 < *nbd> initially the pulse pattern matching will be somewhat hw specific
> 19:14 < *nbd> or at least driver specific
> 
> So ideally if we can generalize things great, I really did not think
> we'd be able to get there on a first step.
It's good to have the pulse pattern matching code be as generic as
possible, but I would like to keep it in the ath module until we're sure
that there actually is non-Atheros hardware out there that it can be
used for (and preferably has been tested with).

I would strongly prefer if it stays in the kernel though, because
certainly not all drivers are going to need pulse pattern matching code
in the driver or stack (some will do this in firmware), and to have two
completely different reporting mechanisms for radar detection events
seems kind of pointless to me.

But even after moving it to the kernel, it would still be nice to have
the code structured in a way that it can alternatively be compiled with
some wrapper code for running user space tests.

- Felix