From: Larry Finger <Larry.Finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC/RFT] mac80211: make tx() operation return void
Date: Tue, 15 Feb 2011 16:19:01 -0600 [thread overview]
Message-ID: <4D5AFBD5.4030309@lwfinger.net> (raw)
In-Reply-To: <1297778837.8664.0.camel@jlt3.sipsolutions.net>
On 02/15/2011 08:07 AM, Johannes Berg wrote:
> From: Johannes Berg<johannes.berg@intel.com>
>
> The return value of the tx operation is commonly
> misused by drivers, leading to errors. All drivers
> will drop frames if they fail to TX the frame, and
> they must also properly manage the queues (if they
> didn't, mac80211 would already warn).
>
> Removing the ability for drivers to return a BUSY
> value also allows significant cleanups of the TX
> TX handling code in mac80211.
>
> NB: Also fixes a bug in ath9k_htc.
>
> Signed-off-by: Johannes Berg<johannes.berg@intel.com>
> ---
> drivers/net/wireless/adm8211.c | 4
> drivers/net/wireless/at76c50x-usb.c | 7 -
> drivers/net/wireless/ath/ar9170/ar9170.h | 2
> drivers/net/wireless/ath/ar9170/main.c | 5
> drivers/net/wireless/ath/ath5k/base.c | 5
> drivers/net/wireless/ath/ath5k/mac80211-ops.c | 10 -
> drivers/net/wireless/ath/ath9k/htc_drv_main.c | 7 -
> drivers/net/wireless/ath/ath9k/main.c | 6
> drivers/net/wireless/ath/carl9170/carl9170.h | 2
> drivers/net/wireless/ath/carl9170/tx.c | 5
> drivers/net/wireless/b43/main.c | 5
> drivers/net/wireless/b43legacy/main.c | 5
> drivers/net/wireless/iwlwifi/iwl-agn.c | 3
> drivers/net/wireless/iwlwifi/iwl-agn.h | 2
> drivers/net/wireless/iwlwifi/iwl3945-base.c | 3
> drivers/net/wireless/libertas_tf/main.c | 3
> drivers/net/wireless/mac80211_hwsim.c | 5
> drivers/net/wireless/mwl8k.c | 15 --
> drivers/net/wireless/p54/lmac.h | 2
> drivers/net/wireless/p54/main.c | 2
> drivers/net/wireless/p54/txrx.c | 11 -
> drivers/net/wireless/rt2x00/rt2x00.h | 2
> drivers/net/wireless/rt2x00/rt2x00mac.c | 5
> drivers/net/wireless/rtl818x/rtl8180/dev.c | 8 -
> drivers/net/wireless/rtl818x/rtl8187/dev.c | 6
> drivers/net/wireless/rtlwifi/core.c | 5
> drivers/net/wireless/wl1251/main.c | 4
> drivers/net/wireless/wl12xx/main.c | 4
> drivers/net/wireless/zd1211rw/zd_mac.c | 5
> include/net/mac80211.h | 2
> net/mac80211/driver-ops.h | 4
> net/mac80211/tx.c | 164 ++++++++------------------
> 32 files changed, 113 insertions(+), 205 deletions(-)
ACK for b43legacy, rtl8187, and rtlwifi.
Larry
next prev parent reply other threads:[~2011-02-15 22:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 14:07 [RFC/RFT] mac80211: make tx() operation return void Johannes Berg
2011-02-15 16:03 ` Sujith
2011-02-15 16:05 ` Johannes Berg
2011-02-15 17:06 ` Jussi Kivilinna
2011-02-15 17:10 ` Johannes Berg
2011-02-19 11:54 ` Sedat Dilek
2011-02-19 12:36 ` Johannes Berg
2011-02-15 18:17 ` Sedat Dilek
2011-02-15 21:54 ` Gertjan van Wingerde
2011-02-15 22:19 ` Larry Finger [this message]
2011-02-22 12:27 ` Coelho, Luciano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5AFBD5.4030309@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).