linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Nikolay Ledovskikh <nledovskikh@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	lrodriguez@atheros.com, mickflemm@gmail.com, me@bobcopeland.com
Subject: Re: [PATCH] ath5k: Correct channel setting for ar2317 chip
Date: Thu, 17 Feb 2011 11:25:39 +0100	[thread overview]
Message-ID: <4D5CF7A3.9040809@gmail.com> (raw)
In-Reply-To: <20110217074454.7233f22f.nledovskikh@gmail.com>

On 02/17/2011 05:44 AM, Nikolay Ledovskikh wrote:
> Use correct channel setting function for AR2317

This is as useless as the one before. Why you didn't add there what you
already wrote:
rf2317 handled but not fully, when I tested ahb patch on bullet2 all
seemed to work fine, but it couldn't connect another host (ibss for
example). During an analysis I observed that it's transmitting on
another channel and then I looked into madwifi code and understood that
the problem is in channel setting function.

This is almost perfect and what people want to know. Especially those
who deal with distro bug reports and backport patches to distro kernels...

> Signed-off-by: Nikolay Ledovskikh <nledovskikh@gmail.com>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
> index 78c26fd..c44111f 100644
> --- a/drivers/net/wireless/ath/ath5k/phy.c
> +++ b/drivers/net/wireless/ath/ath5k/phy.c
> @@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
>  	case AR5K_RF5111:
>  		ret = ath5k_hw_rf5111_channel(ah, channel);
>  		break;
> +	case AR5K_RF2317:
>  	case AR5K_RF2425:
>  		ret = ath5k_hw_rf2425_channel(ah, channel);
>  		break;

thanks,
-- 
js

  reply	other threads:[~2011-02-17 10:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-17  4:44 [PATCH] ath5k: Correct channel setting for ar2317 chip Nikolay Ledovskikh
2011-02-17 10:25 ` Jiri Slaby [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-02-18 13:39 [PATCH] ath5k: Correct channel setting for AR2317 chip Nikolay Ledovskikh
2011-02-18 16:59 Nikolay Ledovskikh
2011-02-18 18:27 ` me

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5CF7A3.9040809@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    --cc=me@bobcopeland.com \
    --cc=mickflemm@gmail.com \
    --cc=nledovskikh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).