* [PATCH] ath5k: Correct channel setting for ar2317 chip
@ 2011-02-17 4:44 Nikolay Ledovskikh
2011-02-17 10:25 ` Jiri Slaby
0 siblings, 1 reply; 5+ messages in thread
From: Nikolay Ledovskikh @ 2011-02-17 4:44 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, lrodriguez, mickflemm, me, jirislaby
Use correct channel setting function for AR2317
Signed-off-by: Nikolay Ledovskikh <nledovskikh@gmail.com>
---
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 78c26fd..c44111f 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
case AR5K_RF5111:
ret = ath5k_hw_rf5111_channel(ah, channel);
break;
+ case AR5K_RF2317:
case AR5K_RF2425:
ret = ath5k_hw_rf2425_channel(ah, channel);
break;
--
Best regards, Nikolay Ledovskikh.
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ath5k: Correct channel setting for ar2317 chip
2011-02-17 4:44 [PATCH] ath5k: Correct channel setting for ar2317 chip Nikolay Ledovskikh
@ 2011-02-17 10:25 ` Jiri Slaby
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Slaby @ 2011-02-17 10:25 UTC (permalink / raw)
To: Nikolay Ledovskikh; +Cc: linville, linux-wireless, lrodriguez, mickflemm, me
On 02/17/2011 05:44 AM, Nikolay Ledovskikh wrote:
> Use correct channel setting function for AR2317
This is as useless as the one before. Why you didn't add there what you
already wrote:
rf2317 handled but not fully, when I tested ahb patch on bullet2 all
seemed to work fine, but it couldn't connect another host (ibss for
example). During an analysis I observed that it's transmitting on
another channel and then I looked into madwifi code and understood that
the problem is in channel setting function.
This is almost perfect and what people want to know. Especially those
who deal with distro bug reports and backport patches to distro kernels...
> Signed-off-by: Nikolay Ledovskikh <nledovskikh@gmail.com>
> ---
> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
> index 78c26fd..c44111f 100644
> --- a/drivers/net/wireless/ath/ath5k/phy.c
> +++ b/drivers/net/wireless/ath/ath5k/phy.c
> @@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
> case AR5K_RF5111:
> ret = ath5k_hw_rf5111_channel(ah, channel);
> break;
> + case AR5K_RF2317:
> case AR5K_RF2425:
> ret = ath5k_hw_rf2425_channel(ah, channel);
> break;
thanks,
--
js
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ath5k: Correct channel setting for AR2317 chip
@ 2011-02-18 13:39 Nikolay Ledovskikh
0 siblings, 0 replies; 5+ messages in thread
From: Nikolay Ledovskikh @ 2011-02-18 13:39 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, lrodriguez, mickflemm, me, jirislaby
Correct channel setting function must be used for AR2317.
When I tested ahb patch on bullet2 all seemed to work fine,
but it couldn't connect another host (using ibss for example).
During an analysis I observed that it's transmitting on another
channel. I looked into madwifi code and understood that
the problem is in channel setting function. So atheros RF2317 not
fully handled in the current ath5k version and must be patched.
Signed-off-by: Nikolay Ledovskikh <nledovskikh@gmail.com>
---
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 78c26fd..c44111f 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
case AR5K_RF5111:
ret = ath5k_hw_rf5111_channel(ah, channel);
break;
+ case AR5K_RF2317:
case AR5K_RF2425:
ret = ath5k_hw_rf2425_channel(ah, channel);
break;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ath5k: Correct channel setting for AR2317 chip
@ 2011-02-18 16:59 Nikolay Ledovskikh
2011-02-18 18:27 ` me
0 siblings, 1 reply; 5+ messages in thread
From: Nikolay Ledovskikh @ 2011-02-18 16:59 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, lrodriguez, mickflemm, me, jirislaby
Correct channel setting function must be used for AR2317.
When I tested ahb patch on bullet2 all seemed to work fine,
but it couldn't connect another host (using ibss for example).
During an analysis I observed that it's transmitting on another
channel. I looked into madwifi code and understood that
the problem is in channel setting function. So atheros RF2317 not
fully handled in the current ath5k version and must be patched.
Signed-off-by: Nikolay Ledovskikh <nledovskikh@gmail.com>
---
diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c
index 78c26fd..c44111f 100644
--- a/drivers/net/wireless/ath/ath5k/phy.c
+++ b/drivers/net/wireless/ath/ath5k/phy.c
@@ -1253,6 +1253,7 @@ static int ath5k_hw_channel(struct ath5k_hw *ah,
case AR5K_RF5111:
ret = ath5k_hw_rf5111_channel(ah, channel);
break;
+ case AR5K_RF2317:
case AR5K_RF2425:
ret = ath5k_hw_rf2425_channel(ah, channel);
break;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ath5k: Correct channel setting for AR2317 chip
2011-02-18 16:59 Nikolay Ledovskikh
@ 2011-02-18 18:27 ` me
0 siblings, 0 replies; 5+ messages in thread
From: me @ 2011-02-18 18:27 UTC (permalink / raw)
To: Nikolay Ledovskikh
Cc: linville, linux-wireless, lrodriguez, mickflemm, jirislaby
On Fri, Feb 18, 2011 at 07:59:53PM +0300, Nikolay Ledovskikh wrote:
> Correct channel setting function must be used for AR2317.
> When I tested ahb patch on bullet2 all seemed to work fine,
> but it couldn't connect another host (using ibss for example).
> During an analysis I observed that it's transmitting on another
> channel. I looked into madwifi code and understood that
> the problem is in channel setting function. So atheros RF2317 not
> fully handled in the current ath5k version and must be patched.
>
> Signed-off-by: Nikolay Ledovskikh <nledovskikh@gmail.com>
Thanks!
Acked-by: Bob Copeland <me@bobcopeland.com>
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-02-18 18:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-17 4:44 [PATCH] ath5k: Correct channel setting for ar2317 chip Nikolay Ledovskikh
2011-02-17 10:25 ` Jiri Slaby
-- strict thread matches above, loose matches on Subject: below --
2011-02-18 13:39 [PATCH] ath5k: Correct channel setting for AR2317 chip Nikolay Ledovskikh
2011-02-18 16:59 Nikolay Ledovskikh
2011-02-18 18:27 ` me
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).