From: Stefan Weil <weil@mail.berlios.de>
To: Greg KH <greg@kroah.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Brett Rudley <brudley@broadcom.com>,
Henry Ptasinski <henryp@broadcom.com>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: brcm80211: Fix memory leak after kmalloc failure
Date: Thu, 24 Feb 2011 22:09:38 +0100 [thread overview]
Message-ID: <4D66C912.8090205@mail.berlios.de> (raw)
In-Reply-To: <20110223220533.GA23425@kroah.com>
Am 23.02.2011 23:05, schrieb Greg KH:
> On Sun, Feb 20, 2011 at 12:29:11AM +0100, Stefan Weil wrote:
>> This error was spotted by cppcheck:
>>
>> drivers/staging/brcm80211/phy/wlc_phy_lcn.c:4053: error: Memory leak: ptr
>>
>> Cc: Brett Rudley <brudley@broadcom.com>
>> Cc: Henry Ptasinski <henryp@broadcom.com>
>> Cc: linux-wireless@vger.kernel.org
>> Cc: devel@driverdev.osuosl.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>> ---
>> drivers/staging/brcm80211/phy/wlc_phy_lcn.c | 1 +
>
> What tree did you make this against? This file isn't in the linux-next
> tree anymore.
>
> thanks,
>
> greg k-h
The patch was based on
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git.
In linux-next, the file was moved to a different directory:
from drivers/staging/brcm80211/phy/wlc_phy_lcn.c
to drivers/staging/brcm80211/brcmsmac/phy/wlc_phy_lcn.c
It still needs the same fix. I'll send a new patch based on latest
linux-next.
Regards
Stefan W.
next prev parent reply other threads:[~2011-02-24 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 23:29 [PATCH] staging: brcm80211: Fix memory leak after kmalloc failure Stefan Weil
2011-02-23 22:05 ` Greg KH
2011-02-24 21:09 ` Stefan Weil [this message]
2011-02-24 21:11 ` [PATCH v2] " Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D66C912.8090205@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=brudley@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=henryp@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).