Re: [PATCH] iwlegacy: change some symbols duplicated from iwlwifi directory

[Larry Finger <Larry.Finger@lwfinger.net>]

On 02/25/2011 04:22 PM, Guy, Wey-Yi wrote:
> On Fri, 2011-02-25 at 14:05 -0800, John W. Linville wrote:
>> Sorry about the SPAM -- either I had some network issues here or I
>> _really_ meant for you to see this!! :-)
>>
>> On Fri, Feb 25, 2011 at 04:50:06PM -0500, John W. Linville wrote:
>>> drivers/net/wireless/iwlegacy/built-in.o:(.rodata+0x29f0): multiple definition of `iwl_rates'
>>> drivers/net/wireless/iwlwifi/built-in.o:(.rodata+0xa68): first defined here
>>> powerpc64-linux-ld: Warning: size of symbol `iwl_rates' changed from 143 in drivers/net/wireless/iwlwifi/built-in.o to 130 in drivers/net/wireless/iwlegacy/built-in.o
>>> drivers/net/wireless/iwlegacy/built-in.o:(.data+0x0): multiple definition of `bt_coex_active'
>>> drivers/net/wireless/iwlwifi/built-in.o:(.data+0x668): first defined here
>>> drivers/net/wireless/iwlegacy/built-in.o:(.rodata+0x750): multiple definition of `iwl_eeprom_band_1'
>>> drivers/net/wireless/iwlwifi/built-in.o:(.rodata+0x27d0): first defined here
>>> drivers/net/wireless/iwlegacy/built-in.o:(.rodata+0x3f0): multiple definition of `iwl_bcast_addr'
>>> drivers/net/wireless/iwlwifi/built-in.o:(.rodata+0x24f8): first defined here
>>> drivers/net/wireless/iwlegacy/built-in.o:(.bss+0x3d48): multiple definition of `iwl_debug_level'
>>> drivers/net/wireless/iwlwifi/built-in.o:(.bss+0x21950): first defined here
>>>
> 
> Thank you very much for fix this, we just miss it :-(

I got hit earlier in the week with a similar issue on a patch of mine. It seems
that a "make allyesconfig && make" is worthwhile whenever large changes are
made, particularly when code is being moved.

Larry