* [PATCH] rtlwifi: make gcc happy
@ 2011-02-27 21:16 Alessio Igor Bogani
2011-02-27 21:58 ` Larry Finger
2011-02-28 0:38 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: Alessio Igor Bogani @ 2011-02-27 21:16 UTC (permalink / raw)
To: Larry Finger, Chaoming Li
Cc: linux-wireless, LKML, Tim Bird, Alessio Igor Bogani
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function
Signed-off-by: Alessio Igor Bogani <abogani@kernel.org>
---
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
index bf5852f..593eb8e 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
@@ -252,9 +252,9 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct phy_sts_cck_8192s_t *cck_buf;
s8 rx_pwr_all, rx_pwr[4];
- u8 rf_rx_num, evm, pwdb_all;
+ u8 evm, pwdb_all, rf_rx_num = 0;
u8 i, max_spatial_stream;
- u32 rssi, total_rssi;
+ u32 rssi, total_rssi = 0;
bool is_cck_rate;
is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc);
@@ -463,7 +463,7 @@ static void _rtl92ce_update_rxsignalstatistics(struct ieee80211_hw *hw,
struct rtl_stats *pstats)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
- int weighting;
+ int weighting = 0;
if (rtlpriv->stats.recv_signal_power == 0)
rtlpriv->stats.recv_signal_power = pstats->recvsignalpower;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] rtlwifi: make gcc happy
2011-02-27 21:16 [PATCH] rtlwifi: make gcc happy Alessio Igor Bogani
@ 2011-02-27 21:58 ` Larry Finger
2011-02-28 0:38 ` Dan Carpenter
1 sibling, 0 replies; 5+ messages in thread
From: Larry Finger @ 2011-02-27 21:58 UTC (permalink / raw)
To: Alessio Igor Bogani; +Cc: Chaoming Li, linux-wireless, LKML, Tim Bird
On 02/27/2011 03:16 PM, Alessio Igor Bogani wrote:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function
>
> Signed-off-by: Alessio Igor Bogani<abogani@kernel.org>
> ---
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> index bf5852f..593eb8e 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> @@ -252,9 +252,9 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct phy_sts_cck_8192s_t *cck_buf;
> s8 rx_pwr_all, rx_pwr[4];
> - u8 rf_rx_num, evm, pwdb_all;
> + u8 evm, pwdb_all, rf_rx_num = 0;
> u8 i, max_spatial_stream;
> - u32 rssi, total_rssi;
> + u32 rssi, total_rssi = 0;
> bool is_cck_rate;
>
> is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc);
> @@ -463,7 +463,7 @@ static void _rtl92ce_update_rxsignalstatistics(struct ieee80211_hw *hw,
> struct rtl_stats *pstats)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> - int weighting;
> + int weighting = 0;
>
> if (rtlpriv->stats.recv_signal_power == 0)
> rtlpriv->stats.recv_signal_power = pstats->recvsignalpower;
ACK. What architecture and compiler version are you using? On x86_64, gcc 4.5.1
does not show these warnings.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] rtlwifi: make gcc happy
2011-02-27 21:16 [PATCH] rtlwifi: make gcc happy Alessio Igor Bogani
2011-02-27 21:58 ` Larry Finger
@ 2011-02-28 0:38 ` Dan Carpenter
2011-02-28 8:11 ` [PATCH] rtlwifi: fix places where uninitialized data is used Alessio Igor Bogani
1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2011-02-28 0:38 UTC (permalink / raw)
To: Alessio Igor Bogani
Cc: Larry Finger, Chaoming Li, linux-wireless, LKML, Tim Bird
On Sun, Feb 27, 2011 at 10:16:30PM +0100, Alessio Igor Bogani wrote:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function
>
These fix actual bugs where uninitialized values are used; it's not
just a matter of silencing warnings. The patch title should mention
that. Perhaps something like:
[patch] rtlwifi: fix places where uninitialized data is used
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] rtlwifi: fix places where uninitialized data is used
2011-02-28 0:38 ` Dan Carpenter
@ 2011-02-28 8:11 ` Alessio Igor Bogani
2011-02-28 18:31 ` Larry Finger
0 siblings, 1 reply; 5+ messages in thread
From: Alessio Igor Bogani @ 2011-02-28 8:11 UTC (permalink / raw)
To: Dan Carpenter, Larry Finger, Chaoming Li
Cc: linux-wireless, LKML, Tim Bird, Alessio Igor Bogani
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function
This work was supported by a hardware donation from the CE Linux Forum.
Signed-off-by: Alessio Igor Bogani <abogani@kernel.org>
---
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
index bf5852f..593eb8e 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
@@ -252,9 +252,9 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct phy_sts_cck_8192s_t *cck_buf;
s8 rx_pwr_all, rx_pwr[4];
- u8 rf_rx_num, evm, pwdb_all;
+ u8 evm, pwdb_all, rf_rx_num = 0;
u8 i, max_spatial_stream;
- u32 rssi, total_rssi;
+ u32 rssi, total_rssi = 0;
bool is_cck_rate;
is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc);
@@ -463,7 +463,7 @@ static void _rtl92ce_update_rxsignalstatistics(struct ieee80211_hw *hw,
struct rtl_stats *pstats)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);
- int weighting;
+ int weighting = 0;
if (rtlpriv->stats.recv_signal_power == 0)
rtlpriv->stats.recv_signal_power = pstats->recvsignalpower;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] rtlwifi: fix places where uninitialized data is used
2011-02-28 8:11 ` [PATCH] rtlwifi: fix places where uninitialized data is used Alessio Igor Bogani
@ 2011-02-28 18:31 ` Larry Finger
0 siblings, 0 replies; 5+ messages in thread
From: Larry Finger @ 2011-02-28 18:31 UTC (permalink / raw)
To: Alessio Igor Bogani, John Linville
Cc: Dan Carpenter, Chaoming Li, linux-wireless, LKML, Tim Bird
On 02/28/2011 02:11 AM, Alessio Igor Bogani wrote:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function
>
> This work was supported by a hardware donation from the CE Linux Forum.
>
> Signed-off-by: Alessio Igor Bogani<abogani@kernel.org>
> ---
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> index bf5852f..593eb8e 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> @@ -252,9 +252,9 @@ static void _rtl92ce_query_rxphystatus(struct ieee80211_hw *hw,
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct phy_sts_cck_8192s_t *cck_buf;
> s8 rx_pwr_all, rx_pwr[4];
> - u8 rf_rx_num, evm, pwdb_all;
> + u8 evm, pwdb_all, rf_rx_num = 0;
> u8 i, max_spatial_stream;
> - u32 rssi, total_rssi;
> + u32 rssi, total_rssi = 0;
> bool is_cck_rate;
>
> is_cck_rate = RX_HAL_IS_CCK_RATE(pdesc);
> @@ -463,7 +463,7 @@ static void _rtl92ce_update_rxsignalstatistics(struct ieee80211_hw *hw,
> struct rtl_stats *pstats)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> - int weighting;
> + int weighting = 0;
>
> if (rtlpriv->stats.recv_signal_power == 0)
> rtlpriv->stats.recv_signal_power = pstats->recvsignalpower;
ACK. Obviously gcc 4.5.1 has a bug and misses these, whereas 4.5.2 finds them.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-02-28 18:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-27 21:16 [PATCH] rtlwifi: make gcc happy Alessio Igor Bogani
2011-02-27 21:58 ` Larry Finger
2011-02-28 0:38 ` Dan Carpenter
2011-02-28 8:11 ` [PATCH] rtlwifi: fix places where uninitialized data is used Alessio Igor Bogani
2011-02-28 18:31 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).