From: "Roland Vossen" <rvossen@broadcom.com>
To: "Javier Martinez Canillas" <martinez.javier@gmail.com>
Cc: "Brett Rudley" <brudley@broadcom.com>,
"Henry Ptasinski" <henryp@broadcom.com>,
"Dowan Kim" <dowan@broadcom.com>,
"Arend Van Spriel" <arend@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH 1/2] staging: brcm80211: Add buf_size parameter to ampdu_action handler function
Date: Mon, 28 Feb 2011 10:50:21 +0100 [thread overview]
Message-ID: <4D6B6FDD.4070202@broadcom.com> (raw)
In-Reply-To: <1298840055-5044-1-git-send-email-martinez.javier@gmail.com>
Hi Javier,
this change looks good to me.
Thanks, Roland.
On 02/27/2011 09:54 PM, Javier Martinez Canillas wrote:
> struct ieee80211_ops.ampdu_action function pointer definition now includes a
> u8 buf_size parameter.
>
> Update wl_ops_ampdu_action handler function according to this new signature.
>
> Signed-off-by: Javier Martinez Canillas<martinez.javier@gmail.com>
> ---
> drivers/staging/brcm80211/brcmsmac/wl_mac80211.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c b/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c
> index 7645c6c..345243b 100644
> --- a/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c
> +++ b/drivers/staging/brcm80211/brcmsmac/wl_mac80211.c
> @@ -142,7 +142,8 @@ static int wl_ops_sta_remove(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
> static int wl_ops_ampdu_action(struct ieee80211_hw *hw,
> struct ieee80211_vif *vif,
> enum ieee80211_ampdu_mlme_action action,
> - struct ieee80211_sta *sta, u16 tid, u16 *ssn);
> + struct ieee80211_sta *sta, u16 tid, u16 *ssn,
> + u8 buf_size);
> static void wl_ops_rfkill_poll(struct ieee80211_hw *hw);
>
> static int wl_ops_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
> @@ -609,7 +610,8 @@ static int
> wl_ops_ampdu_action(struct ieee80211_hw *hw,
> struct ieee80211_vif *vif,
> enum ieee80211_ampdu_mlme_action action,
> - struct ieee80211_sta *sta, u16 tid, u16 *ssn)
> + struct ieee80211_sta *sta, u16 tid, u16 *ssn,
> + u8 buf_size)
> {
> #if defined(BCMDBG)
> struct scb *scb = (struct scb *)sta->drv_priv;
next prev parent reply other threads:[~2011-02-28 9:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-27 20:54 [PATCH 1/2] staging: brcm80211: Add buf_size parameter to ampdu_action handler function Javier Martinez Canillas
2011-02-27 20:54 ` [PATCH 2/2] staging: brcm80211: Remove unused variables and code clean up Javier Martinez Canillas
2011-03-01 3:11 ` Greg KH
2011-03-01 15:37 ` Javier Martinez Canillas
2011-03-01 15:48 ` Greg KH
2011-03-01 16:03 ` Dan Carpenter
2011-03-03 11:30 ` Javier Martinez Canillas
2011-02-28 9:50 ` Roland Vossen [this message]
2011-03-02 19:23 ` [PATCH 1/2] staging: brcm80211: Add buf_size parameter to ampdu_action handler function Arend van Spriel
2011-03-03 11:50 ` Javier Martinez Canillas
2011-03-03 15:38 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6B6FDD.4070202@broadcom.com \
--to=rvossen@broadcom.com \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=dowan@broadcom.com \
--cc=gregkh@suse.de \
--cc=henryp@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=martinez.javier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).