* [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning
@ 2011-03-01 7:23 Ozan Çağlayan
2011-03-01 21:15 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Ozan Çağlayan @ 2011-03-01 7:23 UTC (permalink / raw)
To: linux-wireless; +Cc: gregkh
The TX queues are allocated inside register_netdev.
It doesn't make any sense to stop the queue before
allocation.
Signed-off-by: Ozan Çağlayan <ozan@pardus.org.tr>
---
drivers/staging/rtl8192e/r8192E_core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rtl8192e/r8192E_core.c b/drivers/staging/rtl8192e/r8192E_core.c
index fac4eee..08af4fa 100644
--- a/drivers/staging/rtl8192e/r8192E_core.c
+++ b/drivers/staging/rtl8192e/r8192E_core.c
@@ -6006,7 +6006,6 @@ static int __devinit rtl8192_pci_probe(struct pci_dev *pdev,
}
netif_carrier_off(dev);
- netif_stop_queue(dev);
register_netdev(dev);
RT_TRACE(COMP_INIT, "dev name=======> %s\n",dev->name);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning
2011-03-01 7:23 [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning Ozan Çağlayan
@ 2011-03-01 21:15 ` Greg KH
2011-03-01 21:43 ` Ozan Çağlayan
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2011-03-01 21:15 UTC (permalink / raw)
To: Ozan Çağlayan; +Cc: linux-wireless, gregkh
On Tue, Mar 01, 2011 at 09:23:12AM +0200, Ozan Çağlayan wrote:
> The TX queues are allocated inside register_netdev.
> It doesn't make any sense to stop the queue before
> allocation.
>
> Signed-off-by: Ozan Çağlayan <ozan@pardus.org.tr>
> ---
> drivers/staging/rtl8192e/r8192E_core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
This patch doesn't apply, what tree did you make it against?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning
2011-03-01 21:15 ` Greg KH
@ 2011-03-01 21:43 ` Ozan Çağlayan
2011-03-01 22:01 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Ozan Çağlayan @ 2011-03-01 21:43 UTC (permalink / raw)
To: Greg KH; +Cc: linux-wireless, gregkh
On 01.03.2011 23:15, Greg KH wrote:
> On Tue, Mar 01, 2011 at 09:23:12AM +0200, Ozan Çağlayan wrote:
>> The TX queues are allocated inside register_netdev.
>> It doesn't make any sense to stop the queue before
>> allocation.
>>
>> Signed-off-by: Ozan Çağlayan<ozan@pardus.org.tr>
>> ---
>> drivers/staging/rtl8192e/r8192E_core.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> This patch doesn't apply, what tree did you make it against?
hmm, weird it was on top of an up-to-date linux-2.6 tree.
--
Pardus Linux
http://www.pardus.org.tr/eng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning
2011-03-01 21:43 ` Ozan Çağlayan
@ 2011-03-01 22:01 ` Greg KH
2011-03-01 22:04 ` Ozan Çağlayan
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2011-03-01 22:01 UTC (permalink / raw)
To: Ozan Çağlayan; +Cc: linux-wireless, gregkh
On Tue, Mar 01, 2011 at 11:43:40PM +0200, Ozan Çağlayan wrote:
> On 01.03.2011 23:15, Greg KH wrote:
> >On Tue, Mar 01, 2011 at 09:23:12AM +0200, Ozan Çağlayan wrote:
> >>The TX queues are allocated inside register_netdev.
> >>It doesn't make any sense to stop the queue before
> >>allocation.
> >>
> >>Signed-off-by: Ozan Çağlayan<ozan@pardus.org.tr>
> >>---
> >> drivers/staging/rtl8192e/r8192E_core.c | 1 -
> >> 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> >This patch doesn't apply, what tree did you make it against?
>
> hmm, weird it was on top of an up-to-date linux-2.6 tree.
That's why it doesn't apply, I need patches against the linux-next tree
for stuff to go into the .39 kernel version. Care to rediff this
against that one and resend it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning
2011-03-01 22:01 ` Greg KH
@ 2011-03-01 22:04 ` Ozan Çağlayan
2011-03-03 12:37 ` Ozan Çağlayan
0 siblings, 1 reply; 6+ messages in thread
From: Ozan Çağlayan @ 2011-03-01 22:04 UTC (permalink / raw)
To: Greg KH; +Cc: linux-wireless, gregkh
On 02.03.2011 00:01, Greg KH wrote:
> That's why it doesn't apply, I need patches against the linux-next tree
> for stuff to go into the .39 kernel version. Care to rediff this
> against that one and resend it?
Oh I didn't know that, sorry. I'll refresh and send it tomorrow.
Thanks.
--
Pardus Linux
http://www.pardus.org.tr/eng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning
2011-03-01 22:04 ` Ozan Çağlayan
@ 2011-03-03 12:37 ` Ozan Çağlayan
0 siblings, 0 replies; 6+ messages in thread
From: Ozan Çağlayan @ 2011-03-03 12:37 UTC (permalink / raw)
Cc: linux-wireless, gregkh
02-03-2011 00:04 tarihinde, Ozan Çağlayan yazdı:
> On 02.03.2011 00:01, Greg KH wrote:
>
>> That's why it doesn't apply, I need patches against the linux-next tree
>> for stuff to go into the .39 kernel version. Care to rediff this
>> against that one and resend it?
OK this was already fixed with
commit 6376f210aeca59c89c67efe8ccf28c36bb98b832
Author: Mike McCormack <mikem@ring3k.org>
Date: Mon Jan 31 22:09:15 2011 +0900
Staging: rtl8192e: Don't mess with carrier before registering device
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
in linux-next. Sorry :)
Regards,
Ozan Caglayan
--
Pardus Linux
http://www.pardus.org.tr/eng
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-03 12:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-01 7:23 [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning Ozan Çağlayan
2011-03-01 21:15 ` Greg KH
2011-03-01 21:43 ` Ozan Çağlayan
2011-03-01 22:01 ` Greg KH
2011-03-01 22:04 ` Ozan Çağlayan
2011-03-03 12:37 ` Ozan Çağlayan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).