From: Felix Fietkau <nbd@openwrt.org>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
johannes@sipsolutions.net
Subject: Re: [PATCH 2/2] mac80211: Shortcut minstrel_ht rate setup for non-MRR capable devices
Date: Fri, 04 Mar 2011 18:06:12 +0100 [thread overview]
Message-ID: <4D711C04.8030309@openwrt.org> (raw)
In-Reply-To: <1299241892-6719-2-git-send-email-helmut.schaa@googlemail.com>
On 2011-03-04 1:31 PM, Helmut Schaa wrote:
> Devices without multi rate retry support won't be able to use all rates
> as specified by mintrel_ht. Hence, we can simply skip setting up further
> rates as the devices will only use the first one.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
>
> has_mrr is true if the device is able to make use of at least four rates. Not
> sure if we might want to consider further special cases for devices with for
> example a maximum of two rates.
I think we should add a special case for handling a maximum of two
rates. Right now this is being used by brcm80211, so applying this patch
might make things worse there.
- Felix
next prev parent reply other threads:[~2011-03-04 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 12:31 [PATCH 1/2] mac80211: Remove redundant preamble and RTS flag setup in minstrel_ht Helmut Schaa
2011-03-04 12:31 ` [PATCH 2/2] mac80211: Shortcut minstrel_ht rate setup for non-MRR capable devices Helmut Schaa
2011-03-04 17:06 ` Felix Fietkau [this message]
2011-03-04 17:23 ` Helmut Schaa
2011-03-04 19:34 ` Felix Fietkau
2011-03-04 17:06 ` [PATCH 1/2] mac80211: Remove redundant preamble and RTS flag setup in minstrel_ht Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D711C04.8030309@openwrt.org \
--to=nbd@openwrt.org \
--cc=helmut.schaa@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).