From: Jiri Slaby <jirislaby@gmail.com>
To: Shan Wei <shanwei@cn.fujitsu.com>
Cc: mickflemm@gmail.com, lrodriguez@atheros.com, me@bobcopeland.com,
"John W. Linville" <linville@tuxdriver.com>,
jmalinen@atheros.com, vasanth@atheros.com,
senthilkumar@atheros.com, linux-wireless@vger.kernel.org,
ath5k-devel@lists.ath5k.org, ath9k-devel@lists.ath9k.org
Subject: Re: [PATCH ] wireless:ath: use resource_size() help function
Date: Mon, 07 Mar 2011 08:28:48 +0100 [thread overview]
Message-ID: <4D748930.90906@gmail.com> (raw)
In-Reply-To: <4D7486B3.3090507@cn.fujitsu.com>
On 03/07/2011 08:18 AM, Shan Wei wrote:
>
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
ACK.
> ---
> drivers/net/wireless/ath/ath5k/ahb.c | 2 +-
> drivers/net/wireless/ath/ath9k/ahb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> index ae84b86..82324e9 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -93,7 +93,7 @@ static int ath_ahb_probe(struct platform_device *pdev)
> goto err_out;
> }
>
> - mem = ioremap_nocache(res->start, res->end - res->start + 1);
> + mem = ioremap_nocache(res->start, resource_size(res));
> if (mem == NULL) {
> dev_err(&pdev->dev, "ioremap failed\n");
> ret = -ENOMEM;
> diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
> index 9936721..9cb0efa 100644
> --- a/drivers/net/wireless/ath/ath9k/ahb.c
> +++ b/drivers/net/wireless/ath/ath9k/ahb.c
> @@ -75,7 +75,7 @@ static int ath_ahb_probe(struct platform_device *pdev)
> goto err_out;
> }
>
> - mem = ioremap_nocache(res->start, res->end - res->start + 1);
> + mem = ioremap_nocache(res->start, resource_size(res));
> if (mem == NULL) {
> dev_err(&pdev->dev, "ioremap failed\n");
> ret = -ENOMEM;
thanks,
--
js
prev parent reply other threads:[~2011-03-07 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 7:18 [PATCH ] wireless:ath: use resource_size() help function Shan Wei
2011-03-07 7:28 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D748930.90906@gmail.com \
--to=jirislaby@gmail.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=jmalinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=senthilkumar@atheros.com \
--cc=shanwei@cn.fujitsu.com \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).