From: Larry Finger <Larry.Finger@lwfinger.net>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: Chaoming Li <chaoming_li@realsil.com.cn>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: Fix memset argument order
Date: Thu, 17 Mar 2011 13:41:29 -0500 [thread overview]
Message-ID: <4D8255D9.7010009@lwfinger.net> (raw)
In-Reply-To: <1300385337-27760-1-git-send-email-imirkin@alum.mit.edu>
On 03/17/2011 01:08 PM, Ilia Mirkin wrote:
> These were found using the following semantic match:
> //<smpl>
> @@expression E1; type T;@@
> * memset(E1, ... * sizeof(T) * ..., ...);
> //</smpl>
>
> Also take this opportunity to remove the unnecessary void* casts.
>
> Signed-off-by: Ilia Mirkin<imirkin@alum.mit.edu>
> ---
>
> I do not have the hardware for this, but reading the code, it makes
> sense that the length of the memsets is currently the second argument
> instead of the third.
>
> drivers/net/wireless/rtlwifi/efuse.c | 31 +++++++++++++++----------------
> 1 files changed, 15 insertions(+), 16 deletions(-)
ACK and Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks for finding these.
Larry
prev parent reply other threads:[~2011-03-17 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 18:08 [PATCH] rtlwifi: Fix memset argument order Ilia Mirkin
2011-03-17 18:37 ` Larry Finger
2011-03-17 18:41 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8255D9.7010009@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=imirkin@alum.mit.edu \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).