From: Felix Fietkau <nbd@openwrt.org>
To: Sam Leffler <sleffler@google.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
lrodriguez@atheros.com
Subject: Re: [PATCH 05/10] ath9k_hw: remove pCap->total_queues
Date: Wed, 23 Mar 2011 23:12:57 +0100 [thread overview]
Message-ID: <4D8A7069.6090208@openwrt.org> (raw)
In-Reply-To: <AANLkTinhxdQqjhBXFh6akhkegzrqSpYSgC5=gPhYsp2-@mail.gmail.com>
On 2011-03-23 11:05 PM, Sam Leffler wrote:
> On Wed, Mar 23, 2011 at 12:57 PM, Felix Fietkau <nbd@openwrt.org> wrote:
>> The EEPROM contains a field that can restrict the number of hardware queues,
>> however this is not only useless (all the known chips contain the same
>> number of hardware queues), but also potentially dangerous in case of a
>> misprogrammed EEPROM (could trigger driver crashes), so let's just ignore
>> it completely.
>
> I can't say if there will ever be h/w w/ different #'s of tx q's but I
> think you're better off just capping any value read from eeprom to
> guard against the very unlikely scenario of misprogramming.
I think when chips with fewer or more tx queues show up, we should make
that depend on the SREV, not the EEPROM data.
- Felix
prev parent reply other threads:[~2011-03-23 22:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 19:57 [PATCH 01/10] ath9k_hw: embed the ath_ops callbacks in the ath_hw struct Felix Fietkau
2011-03-23 19:57 ` [PATCH 02/10] ath9k_hw: add a new register op for read-mask-write Felix Fietkau
2011-03-23 19:57 ` [PATCH 03/10] ath9k_hw: replace REG_READ+REG_WRITE with REG_RMW Felix Fietkau
2011-03-23 19:57 ` [PATCH 04/10] ath9k_hw: turn a few big macros into functions Felix Fietkau
2011-03-23 19:57 ` [PATCH 05/10] ath9k_hw: remove pCap->total_queues Felix Fietkau
2011-03-23 19:57 ` [PATCH 06/10] ath9k_hw: remove ah->config.ht_enable Felix Fietkau
2011-03-23 19:57 ` [PATCH 07/10] ath9k_hw: remove pCap->reg_cap Felix Fietkau
2011-03-23 19:57 ` [PATCH 08/10] ath9k_hw: remove pCap->keycache_size Felix Fietkau
2011-03-23 19:57 ` [PATCH 09/10] ath9k_hw: remove ATH9K_HW_CAP_ENHANCEDPM Felix Fietkau
2011-03-23 19:57 ` [PATCH 10/10] ath9k_hw: remove pCap->tx_triglevel_max Felix Fietkau
2011-03-23 22:05 ` [PATCH 05/10] ath9k_hw: remove pCap->total_queues Sam Leffler
2011-03-23 22:12 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8A7069.6090208@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=sleffler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).