* More log spam from brcm80211
@ 2011-03-24 16:11 Larry Finger
2011-03-24 16:34 ` Roland Vossen
2011-03-24 16:37 ` Roland Vossen
0 siblings, 2 replies; 5+ messages in thread
From: Larry Finger @ 2011-03-24 16:11 UTC (permalink / raw)
To: Roland Vossen; +Cc: wireless
Roland,
My logs are getting spammed with lots of "Short CCK" messages that come from the
following code fragment:
if (IS_CCK(rspec)) {
if (rxh->PhyRxStatus_0 & PRXS0_SHORTH)
WL_ERROR("Short CCK\n");
rx_status->flag |= RX_FLAG_SHORTPRE;
} else if (IS_OFDM(rspec)) {
rx_status->flag |= RX_FLAG_SHORTPRE;
} else {
WL_ERROR("%s: Unknown modulation\n", __func__);
}
Logging this condition for debugging might be appropriate, but I do not think it
necessary for general use.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: More log spam from brcm80211
2011-03-24 16:11 More log spam from brcm80211 Larry Finger
@ 2011-03-24 16:34 ` Roland Vossen
2011-03-24 16:37 ` Roland Vossen
1 sibling, 0 replies; 5+ messages in thread
From: Roland Vossen @ 2011-03-24 16:34 UTC (permalink / raw)
To: Larry Finger; +Cc: wireless
Hello Larry,
did you already try my preliminary patch (email that I sent you
yesterday) for the previous log spam problem ?
Regarding this new problem: I will get back to you shortly.
Bye, Roland.
On 03/24/2011 05:11 PM, Larry Finger wrote:
> Roland,
>
> My logs are getting spammed with lots of "Short CCK" messages that come from the
> following code fragment:
>
> if (IS_CCK(rspec)) {
> if (rxh->PhyRxStatus_0& PRXS0_SHORTH)
> WL_ERROR("Short CCK\n");
> rx_status->flag |= RX_FLAG_SHORTPRE;
> } else if (IS_OFDM(rspec)) {
> rx_status->flag |= RX_FLAG_SHORTPRE;
> } else {
> WL_ERROR("%s: Unknown modulation\n", __func__);
> }
>
> Logging this condition for debugging might be appropriate, but I do not think it
> necessary for general use.
>
> Larry
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: More log spam from brcm80211
2011-03-24 16:11 More log spam from brcm80211 Larry Finger
2011-03-24 16:34 ` Roland Vossen
@ 2011-03-24 16:37 ` Roland Vossen
2011-03-24 16:49 ` Larry Finger
1 sibling, 1 reply; 5+ messages in thread
From: Roland Vossen @ 2011-03-24 16:37 UTC (permalink / raw)
To: Larry Finger; +Cc: wireless
Hello Larry,
did you already try my preliminary patch (email that I sent you
yesterday) for the previous log spam problem ?
Regarding this new problem: I will get back to you shortly.
Bye, Roland.
On 03/24/2011 05:11 PM, Larry Finger wrote:
> Roland,
>
> My logs are getting spammed with lots of "Short CCK" messages that come from the
> following code fragment:
>
> if (IS_CCK(rspec)) {
> if (rxh->PhyRxStatus_0& PRXS0_SHORTH)
> WL_ERROR("Short CCK\n");
> rx_status->flag |= RX_FLAG_SHORTPRE;
> } else if (IS_OFDM(rspec)) {
> rx_status->flag |= RX_FLAG_SHORTPRE;
> } else {
> WL_ERROR("%s: Unknown modulation\n", __func__);
> }
>
> Logging this condition for debugging might be appropriate, but I do not think it
> necessary for general use.
>
> Larry
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: More log spam from brcm80211
2011-03-24 16:37 ` Roland Vossen
@ 2011-03-24 16:49 ` Larry Finger
2011-03-25 9:50 ` Roland Vossen
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2011-03-24 16:49 UTC (permalink / raw)
To: Roland Vossen; +Cc: wireless
On 03/24/2011 11:37 AM, Roland Vossen wrote:
> Hello Larry,
>
> did you already try my preliminary patch (email that I sent you yesterday) for
> the previous log spam problem ?
>
> Regarding this new problem: I will get back to you shortly.
Yes, I sent mail yesterday saying that the patch worked. I had to do it manually
as I'm using wireless-testing, not staging-next, and files have been renamed. I
did a full test. With the patch none of the spam appeared in the logs, When I
reverted it, the messages returned.
Larry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: More log spam from brcm80211
2011-03-24 16:49 ` Larry Finger
@ 2011-03-25 9:50 ` Roland Vossen
0 siblings, 0 replies; 5+ messages in thread
From: Roland Vossen @ 2011-03-25 9:50 UTC (permalink / raw)
To: Larry Finger; +Cc: wireless
> Yes, I sent mail yesterday saying that the patch worked. I had to do it manually
> as I'm using wireless-testing, not staging-next, and files have been renamed. I
> did a full test. With the patch none of the spam appeared in the logs, When I
> reverted it, the messages returned.
Great. I just mailed a patch to the dev list (not the linux-wireless
list). Thanks for reporting and testing this.
Bye, Roland.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-25 9:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-24 16:11 More log spam from brcm80211 Larry Finger
2011-03-24 16:34 ` Roland Vossen
2011-03-24 16:37 ` Roland Vossen
2011-03-24 16:49 ` Larry Finger
2011-03-25 9:50 ` Roland Vossen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).