From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com,
IvDoorn@gmail.com, linville@tuxdriver.com, gwingerde@gmail.com
Subject: Re: [PATCH] wireless: rt2x00: rt{2500,73}usb.c fix duplicate ids
Date: Sat, 02 Apr 2011 03:41:13 +0200 [thread overview]
Message-ID: <4D967EB9.9070309@gmail.com> (raw)
In-Reply-To: <1301184953-18436-1-git-send-email-xose.vazquez@gmail.com>
On 03/27/2011 01:15 AM, Xose Vazquez Perez wrote:
> based on the Ralink drivers:
>
> W = Windows_ralink_driver
> L = Linux_ralink_driver
>
> USB_IDs W_73 W_2500 L_73 L_2500
> ============= ==== ====== ==== ======
> 0x050d,0x7050 - - - YES
> 0x050d,0x705a - - YES -
> 0x1371,0x9022 - YES YES -
> 0x148f,0x2573 YES - YES -
>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2500usb.c | 4 ----
> drivers/net/wireless/rt2x00/rt73usb.c | 1 -
> 2 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
> index 979fe65..f6682f0 100644
> --- a/drivers/net/wireless/rt2x00/rt2500usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
> @@ -1910,13 +1910,10 @@ static struct usb_device_id rt2500usb_device_table[] = {
> /* Belkin */
> { USB_DEVICE(0x050d, 0x7050), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x050d, 0x7051), USB_DEVICE_DATA(&rt2500usb_ops) },
> - { USB_DEVICE(0x050d, 0x705a), USB_DEVICE_DATA(&rt2500usb_ops) },
> /* Cisco Systems */
> { USB_DEVICE(0x13b1, 0x000d), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x13b1, 0x0011), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x13b1, 0x001a), USB_DEVICE_DATA(&rt2500usb_ops) },
> - /* CNet */
> - { USB_DEVICE(0x1371, 0x9022), USB_DEVICE_DATA(&rt2500usb_ops) },
> /* Conceptronic */
> { USB_DEVICE(0x14b2, 0x3c02), USB_DEVICE_DATA(&rt2500usb_ops) },
> /* D-LINK */
> @@ -1939,7 +1936,6 @@ static struct usb_device_id rt2500usb_device_table[] = {
> /* Ralink */
> { USB_DEVICE(0x148f, 0x1706), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x148f, 0x2570), USB_DEVICE_DATA(&rt2500usb_ops) },
> - { USB_DEVICE(0x148f, 0x2573), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x148f, 0x9020), USB_DEVICE_DATA(&rt2500usb_ops) },
> /* Sagem */
> { USB_DEVICE(0x079b, 0x004b), USB_DEVICE_DATA(&rt2500usb_ops) },
> diff --git a/drivers/net/wireless/rt2x00/rt73usb.c b/drivers/net/wireless/rt2x00/rt73usb.c
> index 02f1148..bc7a957 100644
> --- a/drivers/net/wireless/rt2x00/rt73usb.c
> +++ b/drivers/net/wireless/rt2x00/rt73usb.c
> @@ -2407,7 +2407,6 @@ static struct usb_device_id rt73usb_device_table[] = {
> { USB_DEVICE(0x0b05, 0x1723), USB_DEVICE_DATA(&rt73usb_ops) },
> { USB_DEVICE(0x0b05, 0x1724), USB_DEVICE_DATA(&rt73usb_ops) },
> /* Belkin */
> - { USB_DEVICE(0x050d, 0x7050), USB_DEVICE_DATA(&rt73usb_ops) },
> { USB_DEVICE(0x050d, 0x705a), USB_DEVICE_DATA(&rt73usb_ops) },
> { USB_DEVICE(0x050d, 0x905b), USB_DEVICE_DATA(&rt73usb_ops) },
> { USB_DEVICE(0x050d, 0x905c), USB_DEVICE_DATA(&rt73usb_ops) },
John, is there any wrong in this patch ?
It wasn't included in your last 'pull request' to davem.
--
«Allá muevan feroz guerra, ciegos reyes por un palmo más de tierra;
que yo aquí tengo por mío cuanto abarca el mar bravío, a quien nadie
impuso leyes. Y no hay playa, sea cualquiera, ni bandera de esplendor,
que no sienta mi derecho y dé pecho a mi valor.»
prev parent reply other threads:[~2011-04-02 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-27 0:15 [PATCH] wireless: rt2x00: rt{2500,73}usb.c fix duplicate ids Xose Vazquez Perez
2011-03-27 9:16 ` Ivo Van Doorn
2011-04-02 1:41 ` Xose Vazquez Perez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D967EB9.9070309@gmail.com \
--to=xose.vazquez@gmail.com \
--cc=IvDoorn@gmail.com \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).