Re: [RFC/RFT 3/9] ath9k_hw: define registers/macros to support Antenna diversity

[Mohammed Shafi <mshajakhan@atheros.com>]

On Friday 29 April 2011 09:50 AM, Vasanth Thiagarajan wrote:
> On Thu, Apr 28, 2011 at 07:52:53PM +0530, Mohammed Shafi Shajakhan wrote:
>    
>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
>> define few registers and macros to configure/enable Antenna diversity
>> parameters in AR9485
>>
>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>> ---
>>   drivers/net/wireless/ath/ath9k/ar9003_phy.h |   31 ++++++++++++++++++++++++--
>>   drivers/net/wireless/ath/ath9k/hw.h         |    3 ++
>>   2 files changed, 31 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_phy.h b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
>> index 2a0d5cb..c4f409f 100644
>> --- a/drivers/net/wireless/ath/ath9k/ar9003_phy.h
>> +++ b/drivers/net/wireless/ath/ath9k/ar9003_phy.h
>> @@ -245,6 +245,9 @@
>>    */
>>   #define AR_BBB_BASE	0x9d00
>>
>> +#define AR_BBB_SIG_DETECT_ANT_FAST_DIV			0x00002000
>> +#define AR_BBB_SIG_DETECT_ANT_FAST_DIV_S		13
>> +
>>   /*
>>    * AGC Register Map
>>    */
>> @@ -261,12 +264,37 @@
>>   #define AR_PHY_EXT_CCA0         (AR_AGC_BASE + 0x20)
>>   #define AR_PHY_RESTART          (AR_AGC_BASE + 0x24)
>>
>> +/*
>> + * Antenna Diversity  settings
>> + */
>>   #define AR_PHY_MC_GAIN_CTRL     (AR_AGC_BASE + 0x28)
>>   #define AR_ANT_DIV_CTRL_ALL	0x7e000000
>>   #define AR_ANT_DIV_CTRL_ALL_S	25
>>   #define AR_ANT_DIV_ENABLE	0x1000000
>>   #define AR_ANT_DIV_ENABLE_S	24
>>
>> +#define AR_PHY_CCK_DETECT       (AR_AGC_BASE + 0x1c0)
>> +#define AR_FAST_DIV_ENABLE	0x2000
>> +#define AR_FAST_DIV_ENABLE_S	13
>>      
> This can be in the original place as it is in order with the
> register offset. This way we can avoid any possible duplication/bug
> in register definition.
>    
Ok Vasanth, I will revert it back.

thanks,
shafi
> Vasanth
> .
>
>