linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mohammed Shafi <mshajakhan@atheros.com>
To: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>
Cc: Mohammed Shajakhan <Mohammed.Shajakhan@Atheros.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	Senthilkumar Balasubramanian
	<Senthilkumar.Balasubramanian@Atheros.com>
Subject: Re: [RFC/RFT 1/9] ath9k_hw: make antenna diversity modules chip	specific
Date: Fri, 29 Apr 2011 10:51:22 +0530	[thread overview]
Message-ID: <4DBA4AD2.4090801@atheros.com> (raw)
In-Reply-To: <20110429041018.GA26690@vasanth-laptop>

On Friday 29 April 2011 09:40 AM, Vasanth Thiagarajan wrote:
> On Thu, Apr 28, 2011 at 07:52:51PM +0530, Mohammed Shafi Shajakhan wrote:
>    
>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
>> this is necessary to support Antenna diversity and combining in new chip
>> sets such as AR9485, previously Antenna diversity support is available
>> only in AR9285
>>
>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>> ---
>>   drivers/net/wireless/ath/ath9k/ar9002_mac.c |    2 ++
>>   drivers/net/wireless/ath/ath9k/ar9002_phy.c |    8 ++++----
>>   drivers/net/wireless/ath/ath9k/hw-ops.h     |   12 ++++++++++++
>>   drivers/net/wireless/ath/ath9k/hw.h         |   15 +++++++++++----
>>   4 files changed, 29 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/ar9002_mac.c b/drivers/net/wireless/ath/ath9k/ar9002_mac.c
>> index c338efb..106714d 100644
>> --- a/drivers/net/wireless/ath/ath9k/ar9002_mac.c
>> +++ b/drivers/net/wireless/ath/ath9k/ar9002_mac.c
>> @@ -458,4 +458,6 @@ void ar9002_hw_attach_mac_ops(struct ath_hw *ah)
>>   	ops->clr11n_aggr = ar9002_hw_clr11n_aggr;
>>   	ops->set11n_burstduration = ar9002_hw_set11n_burstduration;
>>   	ops->set_clrdmask = ar9002_hw_set_clrdmask;
>> +	ops->antdiv_comb_conf_get = ar9002_hw_antdiv_comb_conf_get;
>> +	ops->antdiv_comb_conf_set = ar9002_hw_antdiv_comb_conf_set;
>>      
> This should be part of phy_ops.
>    
Ok I will move it to phy_ops.

thanks,
shafi

> Vasanth
>
> .
>
>    

  reply	other threads:[~2011-04-29  5:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 14:22 [RFC/RFT 0/9] ath9k: Add Antenna diversity support for AR9485 Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 1/9] ath9k_hw: make antenna diversity modules chip specific Mohammed Shafi Shajakhan
2011-04-29  4:10   ` Vasanthakumar Thiagarajan
2011-04-29  5:21     ` Mohammed Shafi [this message]
2011-04-28 14:22 ` [RFC/RFT 2/9] ath9k_hw: enable Antenna diversity for AR9485 Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 3/9] ath9k_hw: define registers/macros to support Antenna diversity Mohammed Shafi Shajakhan
2011-04-29  4:20   ` Vasanthakumar Thiagarajan
2011-04-29  4:53     ` Mohammed Shafi
2011-04-28 14:22 ` [RFC/RFT 4/9] ath9k_hw: config diversity based on eeprom contents Mohammed Shafi Shajakhan
2011-04-28 17:39   ` Luis R. Rodriguez
2011-04-29  4:52     ` Mohammed Shafi
2011-04-29  4:43   ` Vasanthakumar Thiagarajan
2011-04-29  6:34     ` Mohammed Shafi
2011-04-29  6:49     ` Mohammed Shafi
2011-04-28 14:22 ` [RFC/RFT 5/9] ath9k_hw: define modules to get/set Antenna diversity paramaters Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 6/9] ath9k_hw: define antenna diversity group Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 7/9] ath9k: Implement an API to swap main/ALT LNA's Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 8/9] ath9k: configure fast_div_bias based on diversity group Mohammed Shafi Shajakhan
2011-04-28 14:22 ` [RFC/RFT 9/9] ath9k: make sure main_rssi is positive Mohammed Shafi Shajakhan
2011-04-28 18:12 ` [RFC/RFT 0/9] ath9k: Add Antenna diversity support for AR9485 Luis R. Rodriguez
2011-04-28 18:12   ` Luis R. Rodriguez
2011-04-29  4:52     ` Mohammed Shafi
2011-05-12 16:59       ` John W. Linville
2011-05-13  4:22         ` Mohammed Shafi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBA4AD2.4090801@atheros.com \
    --to=mshajakhan@atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=Mohammed.Shajakhan@Atheros.com \
    --cc=Senthilkumar.Balasubramanian@Atheros.com \
    --cc=Vasanth.Thiagarajan@Atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).