Re: Bisected: ath9k: fix powersave frame filtering/buffering in AP mode broke STA association.

[Ben Greear <greearb@candelatech.com>]

On 05/05/2011 02:03 PM, Felix Fietkau wrote:
> On 2011-05-05 10:44 PM, Ben Greear wrote:
>> I bisected the problem I was having with ath9k STA configured for WPA
>> not being able to authenticate.  I'm using nohwcrypt=1, which may
>> be why no one else sees it.

>> I'll be happy to test patches, it seems very easy to reproduce on
>> my setup.
> How about this?
>
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -1270,6 +1270,9 @@ ieee80211_tx_prepare(struct ieee80211_su
>   		info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
>   	else if (test_and_clear_sta_flags(tx->sta, WLAN_STA_CLEAR_PS_FILT))
>   		info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
> +	else if (sdata->vif.type != NL80211_IFTYPE_AP&&
> +	         sdata->vif.type != NL80211_IFTYPE_AP_VLAN)
> +		info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
>
>   	hdrlen = ieee80211_hdrlen(hdr->frame_control);
>   	if (skb->len>  hdrlen + sizeof(rfc1042_header) + 2) {

Yes, that seems to fix the problem.

Thanks for the quick fix!

Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com