linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	"Dan Carpenter" <error27@gmail.com>
Subject: Re: [RFC] lib: crc8: add new library module providing crc8 algorithm
Date: Sun, 22 May 2011 14:47:08 +0200	[thread overview]
Message-ID: <4DD905CC.8040407@broadcom.com> (raw)
In-Reply-To: <20110522122325.108b1c86@lxorguk.ukuu.org.uk>

On 05/22/2011 01:23 PM, Alan Cox wrote:
> On Sat, 21 May 2011 22:49:33 +0200
> "Arend van Spriel"<arend@broadcom.com>  wrote:
>
>> The brcm80211 driver in staging tree uses a crc8 function. Based on
>> feedback from John Linville to move this to lib directory, the linux
>> source has been searched. Although there is currently only one other
>> kernel driver using this algorithm (ie. drivers/ssb) we are providing
>> this as a library function for others to use.
> Can we find a better name for it - there seem to be lots of CRC8 variants
> that are different - eg bit direction and it's going to be confusing to
> just call it 'crc8'

No problem. I just had a look at the lib directory and noticed the crc7 
function and module is called crc7. I can imagine there are enough 
variants of that as well. Another variation is probably the polynomial 
used. Not sure how to factor in bit direction and polynomial into the name.

suggestions from my thumb:
- rnw_crc8: refers to Ross N. Williams who wrote the paper used for 
implementing this function.
- painless_crc8: refers to title of the paper "A Painless Guide to CRC 
Error Detection Algorithms".
- brcm_crc8: indicates where the function came from.

Other suggestions are welcome.

Gr. AvS

-- 
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --



  reply	other threads:[~2011-05-22 12:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21 20:49 [RFC] lib: crc8: add new library module providing crc8 algorithm Arend van Spriel
2011-05-21 22:37 ` Johannes Berg
2011-05-22  8:23   ` Arend van Spriel
2011-05-22 11:23 ` Alan Cox
2011-05-22 12:47   ` Arend van Spriel [this message]
     [not found]     ` <20110522151959.7fd6e87e@lxorguk.ukuu.org.uk>
2011-05-22 15:38       ` Arend van Spriel
2011-05-24  7:45       ` Arend van Spriel
2011-05-24  8:30         ` Arend van Spriel
2011-05-24  9:44         ` Alan Cox
2011-05-24 10:01           ` Arend van Spriel
2011-05-24 10:25             ` Rafał Miłecki
2011-05-24 10:40               ` Arend van Spriel
2011-05-24 10:27             ` Alan Cox
2011-05-24 10:38               ` Arend van Spriel
2011-05-24 12:57                 ` Alan Cox
2011-05-24 17:00                   ` Arend van Spriel
  -- strict thread matches above, loose matches on Subject: below --
2011-05-22  8:08 Arend van Spriel
2011-05-22  8:59 ` Nicolas Kaiser
2011-05-22 12:49   ` Arend van Spriel
2011-05-24 20:23 Arend van Spriel
2011-05-24 22:52 ` George Spelvin
2011-05-25  5:21   ` Arend van Spriel
2011-05-25  5:46     ` George Spelvin
2011-05-25  6:49       ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DD905CC.8040407@broadcom.com \
    --to=arend@broadcom.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).