* [PATCH 7/8] rtlwifi: Use write barrier when assigning ownership
@ 2011-05-23 13:54 Mike McCormack
2011-05-23 19:55 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Mike McCormack @ 2011-05-23 13:54 UTC (permalink / raw)
To: Larry.Finger, chaoming_li; +Cc: linville, linux-wireless
Make sure all updates to a descriptor are flushed to memory
before assigning ownship to hardware.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
---
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
index 54b2bd5..06d9ddb 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
@@ -932,6 +932,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
if (istx == true) {
switch (desc_name) {
case HW_DESC_OWN:
+ wmb();
SET_TX_DESC_OWN(pdesc, 1);
break;
case HW_DESC_TX_NEXTDESC_ADDR:
@@ -945,6 +946,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
} else {
switch (desc_name) {
case HW_DESC_RXOWN:
+ wmb();
SET_RX_DESC_OWN(pdesc, 1);
break;
case HW_DESC_RXBUFF_ADDR:
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 7/8] rtlwifi: Use write barrier when assigning ownership
2011-05-23 13:54 [PATCH 7/8] rtlwifi: Use write barrier when assigning ownership Mike McCormack
@ 2011-05-23 19:55 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2011-05-23 19:55 UTC (permalink / raw)
To: Mike McCormack; +Cc: chaoming_li, linville, linux-wireless
On 05/23/2011 08:54 AM, Mike McCormack wrote:
> Make sure all updates to a descriptor are flushed to memory
> before assigning ownship to hardware.
>
> Signed-off-by: Mike McCormack<mikem@ring3k.org>
> ---
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> index 54b2bd5..06d9ddb 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> @@ -932,6 +932,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
> if (istx == true) {
> switch (desc_name) {
> case HW_DESC_OWN:
> + wmb();
> SET_TX_DESC_OWN(pdesc, 1);
> break;
> case HW_DESC_TX_NEXTDESC_ADDR:
> @@ -945,6 +946,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
> } else {
> switch (desc_name) {
> case HW_DESC_RXOWN:
> + wmb();
> SET_RX_DESC_OWN(pdesc, 1);
> break;
> case HW_DESC_RXBUFF_ADDR:
A similar change needs to be applied to rtl8192se. I'll take care of it.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 7/8] rtlwifi: Use write barrier when assigning ownership
@ 2011-05-25 0:40 Mike McCormack
0 siblings, 0 replies; 4+ messages in thread
From: Mike McCormack @ 2011-05-25 0:40 UTC (permalink / raw)
To: linville; +Cc: Larry.Finger, chaoming_li, linux-wireless
Make sure all updates to a descriptor are flushed to memory
before assigning ownship to hardware.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
index 54b2bd5..06d9ddb 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
@@ -932,6 +932,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
if (istx == true) {
switch (desc_name) {
case HW_DESC_OWN:
+ wmb();
SET_TX_DESC_OWN(pdesc, 1);
break;
case HW_DESC_TX_NEXTDESC_ADDR:
@@ -945,6 +946,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
} else {
switch (desc_name) {
case HW_DESC_RXOWN:
+ wmb();
SET_RX_DESC_OWN(pdesc, 1);
break;
case HW_DESC_RXBUFF_ADDR:
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 7/8] rtlwifi: Use write barrier when assigning ownership
@ 2011-05-30 23:50 Mike McCormack
0 siblings, 0 replies; 4+ messages in thread
From: Mike McCormack @ 2011-05-30 23:50 UTC (permalink / raw)
To: linville; +Cc: Larry.Finger, chaoming_li, linux-wireless
Make sure all updates to a descriptor are flushed to memory
before assigning ownship to hardware.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
index 54b2bd5..06d9ddb 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
@@ -932,6 +932,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
if (istx == true) {
switch (desc_name) {
case HW_DESC_OWN:
+ wmb();
SET_TX_DESC_OWN(pdesc, 1);
break;
case HW_DESC_TX_NEXTDESC_ADDR:
@@ -945,6 +946,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
} else {
switch (desc_name) {
case HW_DESC_RXOWN:
+ wmb();
SET_RX_DESC_OWN(pdesc, 1);
break;
case HW_DESC_RXBUFF_ADDR:
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-30 23:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-23 13:54 [PATCH 7/8] rtlwifi: Use write barrier when assigning ownership Mike McCormack
2011-05-23 19:55 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2011-05-25 0:40 Mike McCormack
2011-05-30 23:50 Mike McCormack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).