From: Larry Finger <Larry.Finger@lwfinger.net>
To: Mike McCormack <mikem@ring3k.org>
Cc: chaoming_li@realsil.com.cn, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/8] rtlwifi: Remove set_rfpowerstate_inprogress
Date: Mon, 23 May 2011 14:46:26 -0500 [thread overview]
Message-ID: <4DDAB992.1050006@lwfinger.net> (raw)
In-Reply-To: <4DDA66F0.5000803@ring3k.org>
On 05/23/2011 08:53 AM, Mike McCormack wrote:
> set_rfpowerstate_inprogress is only set and never read
> so remove it.
>
> Signed-off-by: Mike McCormack<mikem@ring3k.org>
> ---
> drivers/net/wireless/rtlwifi/rtl8192ce/phy.c | 2 --
> drivers/net/wireless/rtlwifi/rtl8192cu/phy.c | 2 --
> drivers/net/wireless/rtlwifi/rtl8192se/phy.c | 4 ----
> drivers/net/wireless/rtlwifi/wifi.h | 1 -
> 4 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c
> index abe0fcc..544e0b7 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c
> @@ -521,7 +521,6 @@ static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw,
> u8 i, queue_id;
> struct rtl8192_tx_ring *ring = NULL;
>
> - ppsc->set_rfpowerstate_inprogress = true;
> switch (rfpwr_state) {
> case ERFON:{
> if ((ppsc->rfpwr_state == ERFOFF)&&
> @@ -617,7 +616,6 @@ static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw,
> }
> if (bresult)
> ppsc->rfpwr_state = rfpwr_state;
> - ppsc->set_rfpowerstate_inprogress = false;
> return bresult;
> }
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c
> index 9a3d023..7285290 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c
> @@ -470,7 +470,6 @@ static bool _rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw,
> u8 i, queue_id;
> struct rtl8192_tx_ring *ring = NULL;
>
> - ppsc->set_rfpowerstate_inprogress = true;
> switch (rfpwr_state) {
> case ERFON:
> if ((ppsc->rfpwr_state == ERFOFF)&&
> @@ -590,7 +589,6 @@ static bool _rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw,
> }
> if (bresult)
> ppsc->rfpwr_state = rfpwr_state;
> - ppsc->set_rfpowerstate_inprogress = false;
> return bresult;
> }
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/phy.c b/drivers/net/wireless/rtlwifi/rtl8192se/phy.c
> index 63b45e6..2ad51b0 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192se/phy.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192se/phy.c
> @@ -546,8 +546,6 @@ bool rtl92s_phy_set_rf_power_state(struct ieee80211_hw *hw,
> if (rfpwr_state == ppsc->rfpwr_state)
> return false;
>
> - ppsc->set_rfpowerstate_inprogress = true;
> -
> switch (rfpwr_state) {
> case ERFON:{
> if ((ppsc->rfpwr_state == ERFOFF)&&
> @@ -659,8 +657,6 @@ bool rtl92s_phy_set_rf_power_state(struct ieee80211_hw *hw,
> if (bresult)
> ppsc->rfpwr_state = rfpwr_state;
>
> - ppsc->set_rfpowerstate_inprogress = false;
> -
> return bresult;
> }
>
> diff --git a/drivers/net/wireless/rtlwifi/wifi.h b/drivers/net/wireless/rtlwifi/wifi.h
> index 693395e..0321328 100644
> --- a/drivers/net/wireless/rtlwifi/wifi.h
> +++ b/drivers/net/wireless/rtlwifi/wifi.h
> @@ -1188,7 +1188,6 @@ struct rtl_efuse {
>
> struct rtl_ps_ctl {
> bool pwrdomain_protect;
> - bool set_rfpowerstate_inprogress;
> bool in_powersavemode;
> bool rfchange_inprogress;
> bool swrf_processing;
Signed-off-by: Larry Finger <Larry.Fionger@lwfinger.net>
---
Larry
next prev parent reply other threads:[~2011-05-23 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 13:53 [PATCH 2/8] rtlwifi: Remove set_rfpowerstate_inprogress Mike McCormack
2011-05-23 19:46 ` Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-25 0:39 Mike McCormack
2011-05-30 23:48 Mike McCormack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDAB992.1050006@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mikem@ring3k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).