* [PATCH 6/8] rtlwifi: Assign rx buffer ownership to hardware last
@ 2011-05-23 13:54 Mike McCormack
2011-05-23 19:52 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Mike McCormack @ 2011-05-23 13:54 UTC (permalink / raw)
To: Larry.Finger, chaoming_li; +Cc: linville, linux-wireless
Ownership of an rx buffer should only be given to the hardware
after all other changes are written, otherwise there's
a potential race.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
---
drivers/net/wireless/rtlwifi/pci.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index fd74396..4fe405a 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -782,8 +782,6 @@ done:
rtlpriv->cfg->ops->set_desc((u8 *) pdesc, false,
HW_DESC_RXBUFF_ADDR,
(u8 *)&bufferaddress);
- rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false, HW_DESC_RXOWN,
- (u8 *)&tmp_one);
rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false,
HW_DESC_RXPKT_LEN,
(u8 *)&rtlpci->rxbuffersize);
@@ -793,6 +791,9 @@ done:
HW_DESC_RXERO,
(u8 *)&tmp_one);
+ rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false, HW_DESC_RXOWN,
+ (u8 *)&tmp_one);
+
index = (index + 1) % rtlpci->rxringcount;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 6/8] rtlwifi: Assign rx buffer ownership to hardware last
2011-05-23 13:54 [PATCH 6/8] rtlwifi: Assign rx buffer ownership to hardware last Mike McCormack
@ 2011-05-23 19:52 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2011-05-23 19:52 UTC (permalink / raw)
To: Mike McCormack; +Cc: chaoming_li, linville, linux-wireless
On 05/23/2011 08:54 AM, Mike McCormack wrote:
> Ownership of an rx buffer should only be given to the hardware
> after all other changes are written, otherwise there's
> a potential race.
>
> Signed-off-by: Mike McCormack<mikem@ring3k.org>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index fd74396..4fe405a 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -782,8 +782,6 @@ done:
> rtlpriv->cfg->ops->set_desc((u8 *) pdesc, false,
> HW_DESC_RXBUFF_ADDR,
> (u8 *)&bufferaddress);
> - rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false, HW_DESC_RXOWN,
> - (u8 *)&tmp_one);
> rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false,
> HW_DESC_RXPKT_LEN,
> (u8 *)&rtlpci->rxbuffersize);
> @@ -793,6 +791,9 @@ done:
> HW_DESC_RXERO,
> (u8 *)&tmp_one);
>
> + rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false, HW_DESC_RXOWN,
> + (u8 *)&tmp_one);
> +
> index = (index + 1) % rtlpci->rxringcount;
> }
>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 6/8] rtlwifi: Assign rx buffer ownership to hardware last
@ 2011-05-25 0:40 Mike McCormack
0 siblings, 0 replies; 4+ messages in thread
From: Mike McCormack @ 2011-05-25 0:40 UTC (permalink / raw)
To: linville; +Cc: Larry.Finger, chaoming_li, linux-wireless
Ownership of an rx buffer should only be given to the hardware
after all other changes are written, otherwise there's
a potential race.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/rtlwifi/pci.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index fd74396..4fe405a 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -782,8 +782,6 @@ done:
rtlpriv->cfg->ops->set_desc((u8 *) pdesc, false,
HW_DESC_RXBUFF_ADDR,
(u8 *)&bufferaddress);
- rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false, HW_DESC_RXOWN,
- (u8 *)&tmp_one);
rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false,
HW_DESC_RXPKT_LEN,
(u8 *)&rtlpci->rxbuffersize);
@@ -793,6 +791,9 @@ done:
HW_DESC_RXERO,
(u8 *)&tmp_one);
+ rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false, HW_DESC_RXOWN,
+ (u8 *)&tmp_one);
+
index = (index + 1) % rtlpci->rxringcount;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 6/8] rtlwifi: Assign rx buffer ownership to hardware last
@ 2011-05-30 23:49 Mike McCormack
0 siblings, 0 replies; 4+ messages in thread
From: Mike McCormack @ 2011-05-30 23:49 UTC (permalink / raw)
To: linville; +Cc: Larry.Finger, chaoming_li, linux-wireless
Ownership of an rx buffer should only be given to the hardware
after all other changes are written, otherwise there's
a potential race.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/rtlwifi/pci.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index fd74396..4fe405a 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -782,8 +782,6 @@ done:
rtlpriv->cfg->ops->set_desc((u8 *) pdesc, false,
HW_DESC_RXBUFF_ADDR,
(u8 *)&bufferaddress);
- rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false, HW_DESC_RXOWN,
- (u8 *)&tmp_one);
rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false,
HW_DESC_RXPKT_LEN,
(u8 *)&rtlpci->rxbuffersize);
@@ -793,6 +791,9 @@ done:
HW_DESC_RXERO,
(u8 *)&tmp_one);
+ rtlpriv->cfg->ops->set_desc((u8 *)pdesc, false, HW_DESC_RXOWN,
+ (u8 *)&tmp_one);
+
index = (index + 1) % rtlpci->rxringcount;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-30 23:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-23 13:54 [PATCH 6/8] rtlwifi: Assign rx buffer ownership to hardware last Mike McCormack
2011-05-23 19:52 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2011-05-25 0:40 Mike McCormack
2011-05-30 23:49 Mike McCormack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).