From: Larry Finger <Larry.Finger@lwfinger.net>
To: Mike McCormack <mikem@ring3k.org>
Cc: chaoming_li@realsil.com.cn, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 7/8] rtlwifi: Use write barrier when assigning ownership
Date: Mon, 23 May 2011 14:55:30 -0500 [thread overview]
Message-ID: <4DDABBB2.4060504@lwfinger.net> (raw)
In-Reply-To: <4DDA6730.7090600@ring3k.org>
On 05/23/2011 08:54 AM, Mike McCormack wrote:
> Make sure all updates to a descriptor are flushed to memory
> before assigning ownship to hardware.
>
> Signed-off-by: Mike McCormack<mikem@ring3k.org>
> ---
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> index 54b2bd5..06d9ddb 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
> @@ -932,6 +932,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
> if (istx == true) {
> switch (desc_name) {
> case HW_DESC_OWN:
> + wmb();
> SET_TX_DESC_OWN(pdesc, 1);
> break;
> case HW_DESC_TX_NEXTDESC_ADDR:
> @@ -945,6 +946,7 @@ void rtl92ce_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val)
> } else {
> switch (desc_name) {
> case HW_DESC_RXOWN:
> + wmb();
> SET_RX_DESC_OWN(pdesc, 1);
> break;
> case HW_DESC_RXBUFF_ADDR:
A similar change needs to be applied to rtl8192se. I'll take care of it.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Larry
next prev parent reply other threads:[~2011-05-23 19:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 13:54 [PATCH 7/8] rtlwifi: Use write barrier when assigning ownership Mike McCormack
2011-05-23 19:55 ` Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-25 0:40 Mike McCormack
2011-05-30 23:50 Mike McCormack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDABBB2.4060504@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mikem@ring3k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).