From: Larry Finger <Larry.Finger@lwfinger.net>
To: Mike McCormack <mikem@ring3k.org>
Cc: chaoming_li@realsil.com.cn, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 8/8] rtlwifi: Fix logic in rx_interrupt
Date: Mon, 23 May 2011 14:57:51 -0500 [thread overview]
Message-ID: <4DDABC3F.2070900@lwfinger.net> (raw)
In-Reply-To: <4DDA673B.6070600@ring3k.org>
On 05/23/2011 08:55 AM, Mike McCormack wrote:
> Should pass along packet if there's no CRC and no hardware error.
>
> Signed-off-by: Mike McCormack<mikem@ring3k.org>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index 4fe405a..215abfa 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -691,7 +691,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
> hdr = rtl_get_hdr(skb);
> fc = rtl_get_fc(skb);
>
> - if (!stats.crc || !stats.hwerror) {
> + if (!stats.crc&& !stats.hwerror) {
> memcpy(IEEE80211_SKB_RXCB(skb),&rx_status,
> sizeof(rx_status));
>
Good catch.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Larry
next prev parent reply other threads:[~2011-05-23 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 13:55 [PATCH 8/8] rtlwifi: Fix logic in rx_interrupt Mike McCormack
2011-05-23 19:57 ` Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-25 0:41 Mike McCormack
2011-05-30 23:50 Mike McCormack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDABC3F.2070900@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mikem@ring3k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).