From: Mohammed Shafi <mshajakhan@atheros.com>
To: Senthilkumar Balasubramanian <Senthilkumar.Balasubramanian@Atheros.com>
Cc: Mohammed Shajakhan <Mohammed.Shajakhan@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH] ath9k: wake up chip before initializing PAPRD table
Date: Tue, 24 May 2011 12:01:13 +0530 [thread overview]
Message-ID: <4DDB50B1.9050701@atheros.com> (raw)
In-Reply-To: <20110524061955.GA5175@ath9k-test>
On Tuesday 24 May 2011 11:50 AM, Senthilkumar Balasubramanian wrote:
> On Tue, May 24, 2011 at 10:31:03AM +0530, Mohammed Shafi Shajakhan wrote:
>> From: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>>
>> in PAPRD table initialization path we have register read. so make sure
>> that the chip is awake. currently PAPRD is disabled.
>>
>> Signed-off-by: Mohammed Shafi Shajakhan<mshajakhan@atheros.com>
>> ---
>> drivers/net/wireless/ath/ath9k/main.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
>> index a198ee3..af8aa9e 100644
>> --- a/drivers/net/wireless/ath/ath9k/main.c
>> +++ b/drivers/net/wireless/ath/ath9k/main.c
>> @@ -394,6 +394,8 @@ void ath_paprd_calibrate(struct work_struct *work)
>> if (!caldata)
>> return;
>>
>> + ath9k_ps_wakeup(sc);
>> +
>> if (ar9003_paprd_init_table(ah)< 0)
>> return;
> Have you tested power save with this patch? ps_restore is missing here...
Senthil, I will look into that.
>>
>> @@ -411,7 +413,6 @@ void ath_paprd_calibrate(struct work_struct *work)
>> memcpy(hdr->addr2, hw->wiphy->perm_addr, ETH_ALEN);
>> memcpy(hdr->addr3, hw->wiphy->perm_addr, ETH_ALEN);
>>
>> - ath9k_ps_wakeup(sc);
>> for (chain = 0; chain< AR9300_MAX_CHAINS; chain++) {
>> if (!(common->tx_chainmask& BIT(chain)))
>> continue;
>> --
>> 1.7.0.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> .
>
--
thanks,
shafi
next prev parent reply other threads:[~2011-05-24 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 5:01 [PATCH] ath9k: wake up chip before initializing PAPRD table Mohammed Shafi Shajakhan
2011-05-24 6:20 ` Senthil Balasubramanian
2011-05-24 6:31 ` Mohammed Shafi [this message]
2011-05-24 7:06 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDB50B1.9050701@atheros.com \
--to=mshajakhan@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Mohammed.Shajakhan@Atheros.com \
--cc=Senthilkumar.Balasubramanian@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).