From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: Ivo van Doorn <IvDoorn@gmail.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH wireless-2.6] rt2x00: fix rmmod crash
Date: Mon, 30 May 2011 08:24:12 +0200 [thread overview]
Message-ID: <4DE3380C.2@gmail.com> (raw)
In-Reply-To: <20110529204200.GA2472@localhost.localdomain>
On 05/29/11 22:42, Stanislaw Gruszka wrote:
> On Sun, May 29, 2011 at 06:48:13PM +0200, Gertjan van Wingerde wrote:
>> On 05/29/11 12:45, Stanislaw Gruszka wrote:
>>> Do not destroy workqueue, which still can be used by autowakeup_work,
>>> before ieee80211_unregister_hw() is called.
>>>
>>> Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
>>
>> Could you add some details of the crash here, e.g. the stack trace of when this occurs, so that
>> we can understand what is exactly happening that is causing the crash, for our education.
>
> Crash is in workqueue code in interrupt context, there is no indication about rt2x00 blame in
> the calltrace, but crash happen directly after rmmod rt73usb, here is a photo:
> https://bugzilla.kernel.org/attachment.cgi?id=59992
OK. Thanks for the info.
Could you create a v2 of the patch that:
1. Includes a reference to the bugzilla entry that the patch is resolving.
2. Cc's the stable team.
In that v2 you can add my acked-by as follows:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
Thanks for the patch.
---
Gertjan
next prev parent reply other threads:[~2011-05-30 6:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 10:45 [PATCH wireless-2.6] rt2x00: fix rmmod crash Stanislaw Gruszka
2011-05-29 16:48 ` Gertjan van Wingerde
2011-05-29 20:42 ` Stanislaw Gruszka
2011-05-30 6:24 ` Gertjan van Wingerde [this message]
2011-05-30 9:52 ` Stanislaw Gruszka
2011-05-30 11:26 ` Gertjan van Wingerde
2011-05-30 12:52 ` Stanislaw Gruszka
2011-05-30 13:42 ` Gertjan van Wingerde
2011-05-30 18:25 ` Ivo Van Doorn
2011-05-31 9:32 ` Stanislaw Gruszka
2011-06-02 17:23 ` Ivo Van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE3380C.2@gmail.com \
--to=gwingerde@gmail.com \
--cc=IvDoorn@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).