* rtl8192se replacing rtl8192e?
@ 2011-05-30 21:34 Ben Hutchings
2011-05-31 3:15 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Ben Hutchings @ 2011-05-30 21:34 UTC (permalink / raw)
To: Chaoming Li, Larry Finger, Mike McCormack; +Cc: linux-wireless
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
I'm happy to see rtl8192se in Linux 3.0-rc1. I noticed that it claims
PCI device ID 10ec:8192, which is already claimed by staging driver
rtl8192e. Is it intended to replace that driver, or are there two
different devices with that ID which they will distinguish in their
probe functions?
If is intended to replace rtl8192e, shouldn't it also claim these device
IDs?
/* Corega */
{ PCI_DEVICE(0x07aa, 0x0044) },
{ PCI_DEVICE(0x07aa, 0x0047) },
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: rtl8192se replacing rtl8192e?
2011-05-30 21:34 rtl8192se replacing rtl8192e? Ben Hutchings
@ 2011-05-31 3:15 ` Larry Finger
2011-05-31 3:20 ` Ben Hutchings
0 siblings, 1 reply; 4+ messages in thread
From: Larry Finger @ 2011-05-31 3:15 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Chaoming Li, Mike McCormack, linux-wireless
On 05/30/2011 04:34 PM, Ben Hutchings wrote:
> I'm happy to see rtl8192se in Linux 3.0-rc1. I noticed that it claims
> PCI device ID 10ec:8192, which is already claimed by staging driver
> rtl8192e. Is it intended to replace that driver, or are there two
> different devices with that ID which they will distinguish in their
> probe functions?
>
> If is intended to replace rtl8192e, shouldn't it also claim these device
> IDs?
>
> /* Corega */
> { PCI_DEVICE(0x07aa, 0x0044) },
> { PCI_DEVICE(0x07aa, 0x0047) },
The RTL8192E is a different device than the RTL8192SE, thus rtl8192se will not
replace rtl8192e. The way to tell them apart is the PCIe revision id. At
present, I don't have a method to use that info to load the correct driver, but
I will be working on it. In addition, I need to acquire an RTL8192E.
No, rtl8192se should not claim those Corega devices.
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: rtl8192se replacing rtl8192e?
2011-05-31 3:15 ` Larry Finger
@ 2011-05-31 3:20 ` Ben Hutchings
2011-05-31 3:29 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Ben Hutchings @ 2011-05-31 3:20 UTC (permalink / raw)
To: Larry Finger; +Cc: Chaoming Li, Mike McCormack, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
On Mon, 2011-05-30 at 22:15 -0500, Larry Finger wrote:
> On 05/30/2011 04:34 PM, Ben Hutchings wrote:
> > I'm happy to see rtl8192se in Linux 3.0-rc1. I noticed that it claims
> > PCI device ID 10ec:8192, which is already claimed by staging driver
> > rtl8192e. Is it intended to replace that driver, or are there two
> > different devices with that ID which they will distinguish in their
> > probe functions?
> >
> > If is intended to replace rtl8192e, shouldn't it also claim these device
> > IDs?
> >
> > /* Corega */
> > { PCI_DEVICE(0x07aa, 0x0044) },
> > { PCI_DEVICE(0x07aa, 0x0047) },
>
> The RTL8192E is a different device than the RTL8192SE, thus rtl8192se will not
> replace rtl8192e. The way to tell them apart is the PCIe revision id. At
> present, I don't have a method to use that info to load the correct driver, but
> I will be working on it.
It doesn't matter too much if both drivers get loaded, so long as their
respective probe() functions fail cleanly and return -ENODEV when called
for the wrong device.
> In addition, I need to acquire an RTL8192E.
>
> No, rtl8192se should not claim those Corega devices.
Thanks.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: rtl8192se replacing rtl8192e?
2011-05-31 3:20 ` Ben Hutchings
@ 2011-05-31 3:29 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2011-05-31 3:29 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Chaoming Li, Mike McCormack, linux-wireless
On 05/30/2011 10:20 PM, Ben Hutchings wrote:
> On Mon, 2011-05-30 at 22:15 -0500, Larry Finger wrote:
>> On 05/30/2011 04:34 PM, Ben Hutchings wrote:
>>> I'm happy to see rtl8192se in Linux 3.0-rc1. I noticed that it claims
>>> PCI device ID 10ec:8192, which is already claimed by staging driver
>>> rtl8192e. Is it intended to replace that driver, or are there two
>>> different devices with that ID which they will distinguish in their
>>> probe functions?
>>>
>>> If is intended to replace rtl8192e, shouldn't it also claim these device
>>> IDs?
>>>
>>> /* Corega */
>>> { PCI_DEVICE(0x07aa, 0x0044) },
>>> { PCI_DEVICE(0x07aa, 0x0047) },
>>
>> The RTL8192E is a different device than the RTL8192SE, thus rtl8192se will not
>> replace rtl8192e. The way to tell them apart is the PCIe revision id. At
>> present, I don't have a method to use that info to load the correct driver, but
>> I will be working on it.
>
> It doesn't matter too much if both drivers get loaded, so long as their
> respective probe() functions fail cleanly and return -ENODEV when called
> for the wrong device.
Yes, I understand the issue and I have trial patches but no hardware for testing.
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-31 3:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-30 21:34 rtl8192se replacing rtl8192e? Ben Hutchings
2011-05-31 3:15 ` Larry Finger
2011-05-31 3:20 ` Ben Hutchings
2011-05-31 3:29 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).