linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	"b43-dev@lists.infradead.org" <b43-dev@lists.infradead.org>
Subject: Re: [PATCH] bcma: read SPROM and extract MAC from it
Date: Thu, 2 Jun 2011 16:52:16 +0200	[thread overview]
Message-ID: <4DE7A3A0.30109@broadcom.com> (raw)
In-Reply-To: <1306973331-3959-1-git-send-email-zajec5@gmail.com>

On 06/02/2011 02:08 AM, Rafał Miłecki wrote:
> In case of BCMA cards SPROM is located in the ChipCommon core, it is
> not mapped as separated host window. So far we have met only SPROMs rev
> 8.
> SPROM layout seems to be the same as for SSB buses, so we decided to
> share SPROM struct and some defines.
> For now we extract MAC address only, this can be improved of course.
>
> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
>
> +/**************************************************
> + * Validation.
> + **************************************************/
> +
> +static inline u8 bcma_crc8(u8 crc, u8 data)
> +{

Somehow this crc8 looks quite familiar to me ;-) I send out a patch to 
John providing a crc8 as library module so you could consider using 
that. It will probably end up in wireless-testing before this patch (if 
accepted that is).

Gr. AvS

-- 
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --



      reply	other threads:[~2011-06-02 14:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02  0:08 [PATCH] bcma: read SPROM and extract MAC from it Rafał Miłecki
2011-06-02 14:52 ` Arend van Spriel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE7A3A0.30109@broadcom.com \
    --to=arend@broadcom.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).