From: Larry Finger <Larry.Finger@lwfinger.net>
To: Mike McCormack <mikem@ring3k.org>
Cc: chaoming_li@realsil.com.cn, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] rtlwifi: rtl8192{ce,cu,se}: Remove irq_enabled flag
Date: Fri, 17 Jun 2011 10:24:28 -0500 [thread overview]
Message-ID: <4DFB71AC.7040604@lwfinger.net> (raw)
In-Reply-To: <4DF93EBF.1070008@ring3k.org>
On 06/15/2011 06:22 PM, Mike McCormack wrote:
> This should be unnecessary if synchronize_irq is used.
>
> Signed-off-by: Mike McCormack<mikem@ring3k.org>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 3 ---
> drivers/net/wireless/rtlwifi/pci.h | 1 -
> drivers/net/wireless/rtlwifi/rtl8192ce/hw.c | 2 --
> drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | 9 ---------
> drivers/net/wireless/rtlwifi/rtl8192se/hw.c | 4 ----
> 5 files changed, 0 insertions(+), 19 deletions(-)
I am still testing this change; however, I must NACK it on a technicality.
Driver rtl8192de, which is in the pipeline, will fail to compile if irq_enabled
is removed from the rtl_pci struct now. In V2, please do not remove this member.
When the dust clears, I will fix rtl8192de and remove the variable.
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index cb4e5e8..d4c2da8 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -794,9 +794,6 @@ static irqreturn_t _rtl_pci_interrupt(int irq, void *dev_id)
> u32 inta = 0;
> u32 intb = 0;
>
> - if (rtlpci->irq_enabled == 0)
> - return IRQ_HANDLED;
> -
> spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
>
> /*read ISR: 4/8bytes */
> diff --git a/drivers/net/wireless/rtlwifi/pci.h b/drivers/net/wireless/rtlwifi/pci.h
> index 671b1f5..12a25c5 100644
> --- a/drivers/net/wireless/rtlwifi/pci.h
> +++ b/drivers/net/wireless/rtlwifi/pci.h
> @@ -169,7 +169,6 @@ struct rtl_pci {
> bool first_init;
> bool being_init_adapter;
> bool init_ready;
> - bool irq_enabled;
Do not remove this yet.
prev parent reply other threads:[~2011-06-17 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 23:22 [PATCH 1/4] rtlwifi: rtl8192{ce,cu,se}: Remove irq_enabled flag Mike McCormack
2011-06-17 15:24 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFB71AC.7040604@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mikem@ring3k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).