From: Larry Finger <Larry.Finger@lwfinger.net>
To: Mike McCormack <mikem@ring3k.org>
Cc: chaoming_li@realsil.com.cn, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] rtlwifi: rtl8192{c,ce,cu,se}: Remove comparisons of booleans with true
Date: Fri, 17 Jun 2011 10:27:18 -0500 [thread overview]
Message-ID: <4DFB7256.8070307@lwfinger.net> (raw)
In-Reply-To: <4DF93EE1.1090102@ring3k.org>
On 06/15/2011 06:23 PM, Mike McCormack wrote:
> These are a potential source of confusion, as most C code treats all
> non-zero values as true.
>
> Signed-off-by: Mike McCormack<mikem@ring3k.org>
> ---
> drivers/net/wireless/rtlwifi/base.c | 2 +-
> drivers/net/wireless/rtlwifi/core.c | 4 ++--
> drivers/net/wireless/rtlwifi/efuse.c | 8 ++++----
> drivers/net/wireless/rtlwifi/ps.c | 2 +-
> drivers/net/wireless/rtlwifi/rc.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192ce/hw.c | 10 +++++-----
> drivers/net/wireless/rtlwifi/rtl8192ce/led.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192ce/rf.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 6 +++---
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 8 ++++----
> drivers/net/wireless/rtlwifi/rtl8192cu/led.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192cu/rf.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192cu/trx.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192se/dm.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192se/hw.c | 6 +++---
> drivers/net/wireless/rtlwifi/rtl8192se/led.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192se/phy.c | 4 ++--
> drivers/net/wireless/rtlwifi/rtl8192se/rf.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192se/trx.c | 6 +++---
> 20 files changed, 38 insertions(+), 38 deletions(-)
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks for doing this.
Larry
next prev parent reply other threads:[~2011-06-17 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 23:23 [PATCH 4/4] rtlwifi: rtl8192{c,ce,cu,se}: Remove comparisons of booleans with true Mike McCormack
2011-06-17 15:27 ` Larry Finger [this message]
2011-06-17 15:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFB7256.8070307@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mikem@ring3k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).