From: Pavel Roskin <proski@gnu.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, tsyvarev@ispras.ru,
me@bobcopeland.com, mickflemm@gmail.com
Subject: Re: [PATCH v2] ath5k: free sc->ah in ath5k_deinit_softc
Date: Fri, 17 Jun 2011 17:36:10 -0400 [thread overview]
Message-ID: <4DFBC8CA.8020808@gnu.org> (raw)
In-Reply-To: <1308343290-13875-1-git-send-email-linville@tuxdriver.com>
On 06/17/2011 04:41 PM, John W. Linville wrote:
> Nothing else is freeing it, and this mirrors the error handling patch
> already in ath5k_init_softc.
You mean path, of course.
> ath5k_hw_deinit(sc->ah);
> + kfree(sc->ah);
> free_irq(sc->irq, sc);
Looks good to me.
While at that, ath_ahb_remove() misses ieee80211_free_hw(), which is
present in the error handling path in ath_ahb_probe(). I have no AHB
devices to test. Anyone wants to make a (tested) patch?
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2011-06-17 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 20:37 [PATCH] ath5k: free sc->ah in ath5k_deinit_softc John W. Linville
2011-06-17 20:41 ` [PATCH v2] " John W. Linville
2011-06-17 21:36 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFBC8CA.8020808@gnu.org \
--to=proski@gnu.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=tsyvarev@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).