* [PATCH] ath5k: free sc->ah in ath5k_deinit_softc
@ 2011-06-17 20:37 John W. Linville
2011-06-17 20:41 ` [PATCH v2] " John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2011-06-17 20:37 UTC (permalink / raw)
To: linux-wireless; +Cc: tsyvarev, me, mickflemm, John W. Linville
Nothing else is freeing it, and this mirrors the error handling patch
already in ath5k_init_softc.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/ath/ath5k/base.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 3e70b14..a6623dd 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -2960,6 +2960,7 @@ ath5k_deinit_softc(struct ath5k_softc *sc)
* state and potentially want to use them.
*/
ath5k_hw_deinit(sc->ah);
+ kfree(sc->ah);
free_irq(sc->irq, sc);
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] ath5k: free sc->ah in ath5k_deinit_softc
2011-06-17 20:37 [PATCH] ath5k: free sc->ah in ath5k_deinit_softc John W. Linville
@ 2011-06-17 20:41 ` John W. Linville
2011-06-17 21:36 ` Pavel Roskin
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2011-06-17 20:41 UTC (permalink / raw)
To: linux-wireless; +Cc: tsyvarev, me, mickflemm, John W. Linville
Nothing else is freeing it, and this mirrors the error handling patch
already in ath5k_init_softc.
https://bugzilla.kernel.org/show_bug.cgi?id=37592
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Reported-by: Tsyvarev Andrey <tsyvarev@ispras.ru>
---
v2 -- cite bugzilla report
drivers/net/wireless/ath/ath5k/base.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 3e70b14..a6623dd 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -2960,6 +2960,7 @@ ath5k_deinit_softc(struct ath5k_softc *sc)
* state and potentially want to use them.
*/
ath5k_hw_deinit(sc->ah);
+ kfree(sc->ah);
free_irq(sc->irq, sc);
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ath5k: free sc->ah in ath5k_deinit_softc
2011-06-17 20:41 ` [PATCH v2] " John W. Linville
@ 2011-06-17 21:36 ` Pavel Roskin
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Roskin @ 2011-06-17 21:36 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, tsyvarev, me, mickflemm
On 06/17/2011 04:41 PM, John W. Linville wrote:
> Nothing else is freeing it, and this mirrors the error handling patch
> already in ath5k_init_softc.
You mean path, of course.
> ath5k_hw_deinit(sc->ah);
> + kfree(sc->ah);
> free_irq(sc->irq, sc);
Looks good to me.
While at that, ath_ahb_remove() misses ieee80211_free_hw(), which is
present in the error handling path in ath_ahb_probe(). I have no AHB
devices to test. Anyone wants to make a (tested) patch?
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-17 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-17 20:37 [PATCH] ath5k: free sc->ah in ath5k_deinit_softc John W. Linville
2011-06-17 20:41 ` [PATCH v2] " John W. Linville
2011-06-17 21:36 ` Pavel Roskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).