From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Michael Büsch" <m@bues.ch>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
mb@bu3sch.de, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ssb: fix ssb clock rate according to broadcom source
Date: Wed, 22 Jun 2011 17:06:32 -0500 [thread overview]
Message-ID: <4E026768.1070306@lwfinger.net> (raw)
In-Reply-To: <20110622070212.076777c0@Nokia-N900>
On 06/22/2011 02:02 AM, Michael Büsch wrote:
> On Tue, 21 Jun 2011 16:36:38 -0500
> Larry Finger<Larry.Finger@lwfinger.net> wrote:
>> This patch sent me looking to find the public source for this routine. After
>> finding it in the source section of Broadcom-wl, I noticed there is some
>> additional code that is not implemented in the ssb version. Should this
>> additional material be implemented, or is it not applicable?
>
> could you quote that function here? That would be way easier to get what were talking about.
The file in question is found from the Broadcom wl driver. When you untar it
into directory "broadcom", the file is broadcom/src/shared/siutils.c.
My initial conclusion that the clock_rate routine from the above file and
drivers/ssb/main.c were different was wrong. When I checked them again, they do
exactly the same thing after this patch is applied. Sorry for the noise.
Larry
prev parent reply other threads:[~2011-06-22 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 18:31 [PATCH] ssb: fix ssb clock rate according to broadcom source Hauke Mehrtens
2011-06-21 18:53 ` [PATCH v2] " Hauke Mehrtens
2011-06-21 21:36 ` Larry Finger
2011-06-22 7:02 ` Michael Büsch
2011-06-22 22:06 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E026768.1070306@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m@bues.ch \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).