From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:50529 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754792Ab1GAGj0 (ORCPT ); Fri, 1 Jul 2011 02:39:26 -0400 Message-ID: <4E0D6B8D.6000601@gmail.com> (sfid-20110701_083947_868716_9DEC69A5) Date: Thu, 30 Jun 2011 23:39:09 -0700 From: "Justin P. Mattock" MIME-Version: 1.0 To: Mohammed Shafi CC: "linux-kernel@vger.kernel.org" , linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net Subject: Re: WARNING: at kernel/timer.c:1011 del_timer_sync+0xa9/0xc4() References: <4E0D5E42.20702@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/30/2011 11:27 PM, Mohammed Shafi wrote: > On Fri, Jul 1, 2011 at 11:12 AM, Justin P. Mattock > wrote: >> not sure if somebody has posted this or not(did post last week, but no >> replies on this) I would bisect, but have no time(maybe in the future). >> >> anyways let me know if you need more info. >> dmesg here: >> http://fpaste.org/wLxM/ >> >> >> [ 43.108967] SELinux: initialized (dev fusectl, type fusectl), uses >> genfs_contexts >> [ 561.844541] ath: Failed to stop TX DMA! >> [ 1514.074565] ------------[ cut here ]------------ >> [ 1514.074584] WARNING: at kernel/timer.c:1011 del_timer_sync+0xa9/0xc4() >> [ 1514.074590] Hardware name: MacBookPro2,2 >> [ 1514.074595] Modules linked in: fuse 8021q cpufreq_ondemand garp stp >> acpi_cpufreq llc freq_table mperf ipt_REJECT nf_conntrack_ipv4 >> nf_defrag_ipv4 xt_state nf_conntrack iptable_filter ip_tables arc4 radeon >> ath9k mac80211 ttm ath9k_common drm_kms_helper ath9k_hw drm ath cfg80211 >> uvcvideo videodev btusb bluetooth sky2 v4l2_compat_ioctl32 appletouch >> iTCO_wdt i2c_i801 joydev i2c_algo_bit iTCO_vendor_support applesmc rfkill >> i2c_core input_polldev apple_bl video microcode [last unloaded: >> scsi_wait_scan] >> [ 1514.074730] Pid: 1550, comm: threaded-ml Not tainted >> 3.0.0-rc5-00080-gca56a95 #6 >> [ 1514.074735] Call Trace: >> [ 1514.074739] [] warn_slowpath_common+0x83/0x9b >> [ 1514.074758] [] warn_slowpath_null+0x1a/0x1c >> [ 1514.074767] [] del_timer_sync+0xa9/0xc4 >> [ 1514.074775] [] ? process_timeout+0x10/0x10 >> [ 1514.074794] [] ath_reset+0x43/0x1d0 [ath9k] >> [ 1514.074804] [] ? _local_bh_enable_ip+0xca/0xce >> [ 1514.074821] [] ath_tx_complete_aggr+0x7c3/0x7dd [ath9k] >> [ 1514.074837] [] ? ath_tx_flush_tid+0xe0/0xe0 [ath9k] >> [ 1514.074855] [] ath_tx_tasklet+0x235/0x2cb [ath9k] >> [ 1514.074871] [] ath9k_tasklet+0xf4/0x135 [ath9k] >> [ 1514.074880] [] tasklet_action+0x8d/0xed >> [ 1514.074889] [] __do_softirq+0xdb/0x1ec >> [ 1514.074899] [] ? lock_release+0x165/0x18e >> [ 1514.074910] [] call_softirq+0x1c/0x30 >> [ 1514.074919] [] do_softirq+0x4b/0xa1 >> [ 1514.074927] [] irq_exit+0x5d/0xa8 >> [ 1514.074935] [] do_IRQ+0x8e/0xa5 >> [ 1514.074945] [] common_interrupt+0x13/0x13 >> [ 1514.074950] [] ? current_kernel_time+0x13/0x34 >> [ 1514.074968] [] ? sysret_check+0x2e/0x69 >> [ 1514.074977] [] ? trace_hardirqs_on_caller+0x10b/0x12f >> [ 1514.074988] [] audit_syscall_entry+0x11c/0x148 >> [ 1514.074998] [] ? trace_hardirqs_on_thunk+0x3a/0x3f >> [ 1514.075076] [] auditsys+0x19/0x4a >> [ 1514.075084] ---[ end trace 834e058f0ef2c378 ]--- >> [ 1514.075092] ------------[ cut here ]------------ >> [ 1514.075101] WARNING: at kernel/softirq.c:98 >> __local_bh_disable+0x45/0xb1() >> [ 1514.075108] Hardware name: MacBookPro2,2 >> [ 1514.075113] Modules linked in: fuse 8021q cpufreq_ondemand garp stp >> acpi_cpufreq llc freq_table mperf ipt_REJECT nf_conntrack_ipv4 >> nf_defrag_ipv4 xt_state nf_conntrack iptable_filter ip_tables arc4 radeon >> ath9k mac80211 ttm ath9k_common drm_kms_helper ath9k_hw drm ath cfg80211 >> uvcvideo videodev btusb bluetooth sky2 v4l2_compat_ioctl32 appletouch >> iTCO_wdt i2c_i801 joydev i2c_algo_bit iTCO_vendor_support applesmc rfkill >> i2c_core input_polldev apple_bl video microcode [last unloaded: >> scsi_wait_scan] >> [ 1514.075271] Pid: 1550, comm: threaded-ml Tainted: G W >> 3.0.0-rc5-00080-gca56a95 #6 >> [ 1514.075278] Call Trace: >> [ 1514.075283] [] warn_slowpath_common+0x83/0x9b >> [ 1514.075303] [] ? _raw_spin_lock_bh+0x16/0x45 >> [ 1514.075313] [] warn_slowpath_null+0x1a/0x1c >> [ 1514.075324] [] __local_bh_disable+0x45/0xb1 >> [ 1514.075333] [] local_bh_disable+0x17/0x19 >> [ 1514.075344] [] _raw_spin_lock_bh+0x16/0x45 >> [ 1514.075362] [] ath_reset+0x5e/0x1d0 [ath9k] >> [ 1514.075372] [] ? _local_bh_enable_ip+0xca/0xce >> [ 1514.075391] [] ath_tx_complete_aggr+0x7c3/0x7dd [ath9k] >> [ 1514.075409] [] ? ath_tx_flush_tid+0xe0/0xe0 [ath9k] >> [ 1514.075428] [] ath_tx_tasklet+0x235/0x2cb [ath9k] >> [ 1514.075445] [] ath9k_tasklet+0xf4/0x135 [ath9k] >> [ 1514.075456] [] tasklet_action+0x8d/0xed >> [ 1514.075465] [] __do_softirq+0xdb/0x1ec >> [ 1514.075476] [] ? lock_release+0x165/0x18e >> [ 1514.075487] [] call_softirq+0x1c/0x30 >> [ 1514.075496] [] do_softirq+0x4b/0xa1 >> [ 1514.075505] [] irq_exit+0x5d/0xa8 >> [ 1514.075514] [] do_IRQ+0x8e/0xa5 >> [ 1514.075524] [] common_interrupt+0x13/0x13 >> [ 1514.075529] [] ? current_kernel_time+0x13/0x34 >> [ 1514.075548] [] ? sysret_check+0x2e/0x69 >> [ 1514.075559] [] ? trace_hardirqs_on_caller+0x10b/0x12f >> [ 1514.075570] [] audit_syscall_entry+0x11c/0x148 >> [ 1514.075580] [] ? trace_hardirqs_on_thunk+0x3a/0x3f >> [ 1514.075590] [] auditsys+0x19/0x4a >> [ 1514.075596] ---[ end trace 834e058f0ef2c379 ]--- > > this commit seems to fix it, what did you do to get this warning? > thanks! will revert this and see if it fixes this. as for what I was doing, nothing just streaming radio, and cunducting regular business, emails, twizzles, etc.. > commit f6b4e4d476b890e1ddebbed8ec4924f9c2750a31 > Author: Rajkumar Manoharan > Date: Fri Jun 24 17:38:13 2011 +0530 > > ath9k: Fix locking issue during tx completion > > The received tx status of aggregated frame without BlockAck may > cause deaf state in AR5416 cards. So the driver does a reset to > recover. When this happens, we release the pcu_lock before doing > a reset as ath_rest acquires pcu_lock. This is ugly and also not > atomic. Fixing this addresses the TX DMA failure also. > > ath_tx_complete_aggr can be called from different paths which > takes different variants of spin_lock. This patch also addresses > the following warning. > > WARNING: at kernel/timer.c:1011 del_timer_sync+0x4e/0x50() > Call Trace: > [] warn_slowpath_common+0x7a/0xb0 > [] warn_slowpath_null+0x15/0x20 > [] del_timer_sync+0x4e/0x50 > [] ath_reset+0x3e/0x210 [ath9k] > [] ? _raw_spin_unlock_bh+0x1f/0x30 > [] ath_tx_complete_aggr.isra.26+0x54a/0xa40 [ath9k] > > Signed-off-by: Rajkumar Manoharan > Signed-off-by: John W. Linville > > > >> >> Justin P. Mattock >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > >