* [PATCH 1/8] ath5k: add missing checks for rfgain probe @ 2011-07-04 5:47 Felix Fietkau 2011-07-04 5:47 ` [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Felix Fietkau 2011-07-04 9:48 ` [PATCH 1/8] ath5k: add missing checks for rfgain probe Nick Kossifidis 0 siblings, 2 replies; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 5:47 UTC (permalink / raw) To: linux-wireless; +Cc: linville, ath5k-devel rfgain probe is only necessary for OFDM operation on AR5112 and no other radio chips Signed-off-by: Felix Fietkau <nbd@openwrt.org> --- drivers/net/wireless/ath/ath5k/phy.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index 5544191..c774468 100644 --- a/drivers/net/wireless/ath/ath5k/phy.c +++ b/drivers/net/wireless/ath/ath5k/phy.c @@ -1604,11 +1604,12 @@ int ath5k_hw_phy_calibrate(struct ath5k_hw *ah, int ret; if (ah->ah_radio == AR5K_RF5110) - ret = ath5k_hw_rf5110_calibrate(ah, channel); - else { - ret = ath5k_hw_rf511x_iq_calibrate(ah); + return ath5k_hw_rf5110_calibrate(ah, channel); + + ret = ath5k_hw_rf511x_iq_calibrate(ah); + + if (ah->ah_radio == AR5K_RF5112 && (channel->hw_value & CHANNEL_OFDM)) ath5k_hw_request_rfgain_probe(ah); - } return ret; } -- 1.7.3.2 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 2011-07-04 5:47 [PATCH 1/8] ath5k: add missing checks for rfgain probe Felix Fietkau @ 2011-07-04 5:47 ` Felix Fietkau 2011-07-04 5:47 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Felix Fietkau 2011-07-04 10:29 ` [ath5k-devel] [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Nick Kossifidis 2011-07-04 9:48 ` [PATCH 1/8] ath5k: add missing checks for rfgain probe Nick Kossifidis 1 sibling, 2 replies; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 5:47 UTC (permalink / raw) To: linux-wireless; +Cc: linville, ath5k-devel Might fix some stability issues on newer chips Signed-off-by: Felix Fietkau <nbd@openwrt.org> --- drivers/net/wireless/ath/ath5k/phy.c | 19 +++++++++++-------- 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index c774468..f66124a 100644 --- a/drivers/net/wireless/ath/ath5k/phy.c +++ b/drivers/net/wireless/ath/ath5k/phy.c @@ -970,17 +970,20 @@ static int ath5k_hw_rfregs_init(struct ath5k_hw *ah, } /* Lower synth voltage on Rev 2 */ - ath5k_hw_rfb_op(ah, rf_regs, 2, - AR5K_RF_HIGH_VC_CP, true); + if (ah->ah_radio == AR5K_RF5112 && + (ah->ah_radio_5ghz_revision & AR5K_SREV_REV) > 0) { + ath5k_hw_rfb_op(ah, rf_regs, 2, + AR5K_RF_HIGH_VC_CP, true); - ath5k_hw_rfb_op(ah, rf_regs, 2, - AR5K_RF_MID_VC_CP, true); + ath5k_hw_rfb_op(ah, rf_regs, 2, + AR5K_RF_MID_VC_CP, true); - ath5k_hw_rfb_op(ah, rf_regs, 2, - AR5K_RF_LOW_VC_CP, true); + ath5k_hw_rfb_op(ah, rf_regs, 2, + AR5K_RF_LOW_VC_CP, true); - ath5k_hw_rfb_op(ah, rf_regs, 2, - AR5K_RF_PUSH_UP, true); + ath5k_hw_rfb_op(ah, rf_regs, 2, + AR5K_RF_PUSH_UP, true); + } /* Decrease power consumption on 5213+ BaseBand */ if (ah->ah_phy_revision >= AR5K_SREV_PHY_5212A) { -- 1.7.3.2 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 2011-07-04 5:47 ` [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Felix Fietkau @ 2011-07-04 5:47 ` Felix Fietkau [not found] ` <1309758467-1712-4-git-send-email-nbd@openwrt.org> 2011-07-04 10:27 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Nick Kossifidis 2011-07-04 10:29 ` [ath5k-devel] [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Nick Kossifidis 1 sibling, 2 replies; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 5:47 UTC (permalink / raw) To: linux-wireless; +Cc: linville, ath5k-devel AR2413 uses the same reference clock as AR5413 Signed-off-by: Felix Fietkau <nbd@openwrt.org> --- drivers/net/wireless/ath/ath5k/phy.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index f66124a..c65c33a 100644 --- a/drivers/net/wireless/ath/ath5k/phy.c +++ b/drivers/net/wireless/ath/ath5k/phy.c @@ -105,6 +105,7 @@ bool ath5k_hw_chan_has_spur_noise(struct ath5k_hw *ah, if ((ah->ah_radio == AR5K_RF5112) || (ah->ah_radio == AR5K_RF5413) || + (ah->ah_radio == AR5K_RF2413) || (ah->ah_mac_version == (AR5K_SREV_AR2417 >> 4))) refclk_freq = 40; else -- 1.7.3.2 ^ permalink raw reply related [flat|nested] 21+ messages in thread
[parent not found: <1309758467-1712-4-git-send-email-nbd@openwrt.org>]
* [PATCH 5/8] ath5k: delay full calibration after reset [not found] ` <1309758467-1712-4-git-send-email-nbd@openwrt.org> @ 2011-07-04 5:47 ` Felix Fietkau 2011-07-04 5:47 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Felix Fietkau 2011-07-04 10:34 ` [ath5k-devel] [PATCH 5/8] ath5k: delay full calibration after reset Nick Kossifidis 2011-07-04 10:40 ` [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate Nick Kossifidis 1 sibling, 2 replies; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 5:47 UTC (permalink / raw) To: linux-wireless; +Cc: linville, ath5k-devel During scans the full calibration usually does not make much sense, PAPD probing and IQ calibration should be deferred until there is enough time to complete them. Adding 100 ms to the initial full calibration delay should be enough to do this. Signed-off-by: Felix Fietkau <nbd@openwrt.org> --- drivers/net/wireless/ath/ath5k/base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index a413aa7..efec14f 100644 --- a/drivers/net/wireless/ath/ath5k/base.c +++ b/drivers/net/wireless/ath/ath5k/base.c @@ -2728,7 +2728,7 @@ ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan, ath5k_ani_init(ah, ani_mode); - ah->ah_cal_next_full = jiffies; + ah->ah_cal_next_full = jiffies + msecs_to_jiffies(100); ah->ah_cal_next_ani = jiffies; ah->ah_cal_next_nf = jiffies; ewma_init(&ah->ah_beacon_rssi_avg, 1024, 8); -- 1.7.3.2 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 6/8] ath5k: fix reference clock usec duration setting restore 2011-07-04 5:47 ` [PATCH 5/8] ath5k: delay full calibration after reset Felix Fietkau @ 2011-07-04 5:47 ` Felix Fietkau 2011-07-04 5:47 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Felix Fietkau 2011-07-04 10:25 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Nick Kossifidis 2011-07-04 10:34 ` [ath5k-devel] [PATCH 5/8] ath5k: delay full calibration after reset Nick Kossifidis 1 sibling, 2 replies; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 5:47 UTC (permalink / raw) To: linux-wireless; +Cc: linville, ath5k-devel enabling the sleep clock alters the AR5K_USEC_32 field, but disabling it didn't restore it. Signed-off-by: Felix Fietkau <nbd@openwrt.org> --- drivers/net/wireless/ath/ath5k/reset.c | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c index 1676a3e..55276ce 100644 --- a/drivers/net/wireless/ath/ath5k/reset.c +++ b/drivers/net/wireless/ath/ath5k/reset.c @@ -233,7 +233,7 @@ static void ath5k_hw_init_core_clock(struct ath5k_hw *ah) static void ath5k_hw_set_sleep_clock(struct ath5k_hw *ah, bool enable) { struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom; - u32 scal, spending; + u32 scal, spending, sclock; /* Only set 32KHz settings if we have an external * 32KHz crystal present */ @@ -317,6 +317,15 @@ static void ath5k_hw_set_sleep_clock(struct ath5k_hw *ah, bool enable) /* Set up tsf increment on each cycle */ AR5K_REG_WRITE_BITS(ah, AR5K_TSF_PARM, AR5K_TSF_PARM_INC, 1); + + if ((ah->ah_radio == AR5K_RF5112) || + (ah->ah_radio == AR5K_RF5413) || + (ah->ah_radio == AR5K_RF2316) || + (ah->ah_radio == AR5K_RF2317)) + sclock = 40 - 1; + else + sclock = 32 - 1; + AR5K_REG_WRITE_BITS(ah, AR5K_USEC_5211, AR5K_USEC_32, sclock); } } -- 1.7.3.2 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 7/8] ath5k: disable 32KHz sleep clock operation 2011-07-04 5:47 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Felix Fietkau @ 2011-07-04 5:47 ` Felix Fietkau 2011-07-04 5:47 ` [PATCH 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211 Felix Fietkau 2011-07-04 9:58 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Nick Kossifidis 2011-07-04 10:25 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Nick Kossifidis 1 sibling, 2 replies; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 5:47 UTC (permalink / raw) To: linux-wireless; +Cc: linville, ath5k-devel While 32 KHz sleep clock might provide some power saving benefits, it is also a major source of stability issues, on OpenWrt it produced some reproducible data bus errors on register accesses on several different MIPS platforms. All the Atheros drivers that I can find do not enable this feature, so it makes sense to leave it disabled in ath5k as well. Signed-off-by: Felix Fietkau <nbd@openwrt.org> --- drivers/net/wireless/ath/ath5k/reset.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c index 55276ce..192c0cb 100644 --- a/drivers/net/wireless/ath/ath5k/reset.c +++ b/drivers/net/wireless/ath/ath5k/reset.c @@ -1285,15 +1285,6 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode, */ ath5k_hw_dma_init(ah); - - /* Enable 32KHz clock function for AR5212+ chips - * Set clocks to 32KHz operation and use an - * external 32KHz crystal when sleeping if one - * exists */ - if (ah->ah_version == AR5K_AR5212 && - op_mode != NL80211_IFTYPE_AP) - ath5k_hw_set_sleep_clock(ah, true); - /* * Disable beacons and reset the TSF */ -- 1.7.3.2 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211 2011-07-04 5:47 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Felix Fietkau @ 2011-07-04 5:47 ` Felix Fietkau 2011-07-04 9:58 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Nick Kossifidis 1 sibling, 0 replies; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 5:47 UTC (permalink / raw) To: linux-wireless; +Cc: linville, ath5k-devel Instead of using ieee80211_stop_queue, check the configured tx queue limit before calling ieee80211_get_buffered_bc. Signed-off-by: Felix Fietkau <nbd@openwrt.org> --- drivers/net/wireless/ath/ath5k/base.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c index efec14f..d889f33 100644 --- a/drivers/net/wireless/ath/ath5k/base.c +++ b/drivers/net/wireless/ath/ath5k/base.c @@ -1555,7 +1555,8 @@ ath5k_tx_queue(struct ieee80211_hw *hw, struct sk_buff *skb, goto drop_packet; } - if (txq->txq_len >= txq->txq_max) + if (txq->txq_len >= txq->txq_max && + txq->qnum <= AR5K_TX_QUEUE_ID_DATA_MAX) ieee80211_stop_queue(hw, txq->qnum); spin_lock_irqsave(&sc->txbuflock, flags); @@ -1931,6 +1932,10 @@ ath5k_beacon_send(struct ath5k_softc *sc) skb = ieee80211_get_buffered_bc(sc->hw, vif); while (skb) { ath5k_tx_queue(sc->hw, skb, sc->cabq); + + if (sc->cabq->txq_len >= sc->cabq->txq_max) + break; + skb = ieee80211_get_buffered_bc(sc->hw, vif); } -- 1.7.3.2 ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH 7/8] ath5k: disable 32KHz sleep clock operation 2011-07-04 5:47 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Felix Fietkau 2011-07-04 5:47 ` [PATCH 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211 Felix Fietkau @ 2011-07-04 9:58 ` Nick Kossifidis 2011-07-04 10:07 ` Felix Fietkau 1 sibling, 1 reply; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 9:58 UTC (permalink / raw) To: Felix Fietkau; +Cc: linux-wireless, linville, ath5k-devel 2011/7/4 Felix Fietkau <nbd@openwrt.org>: > While 32 KHz sleep clock might provide some power saving benefits, > it is also a major source of stability issues, on OpenWrt it produced > some reproducible data bus errors on register accesses on several > different MIPS platforms. > > All the Atheros drivers that I can find do not enable this feature, > so it makes sense to leave it disabled in ath5k as well. > > Signed-off-by: Felix Fietkau <nbd@openwrt.org> > --- > drivers/net/wireless/ath/ath5k/reset.c | 9 --------- > 1 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c > index 55276ce..192c0cb 100644 > --- a/drivers/net/wireless/ath/ath5k/reset.c > +++ b/drivers/net/wireless/ath/ath5k/reset.c > @@ -1285,15 +1285,6 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode, > */ > ath5k_hw_dma_init(ah); > > - > - /* Enable 32KHz clock function for AR5212+ chips > - * Set clocks to 32KHz operation and use an > - * external 32KHz crystal when sleeping if one > - * exists */ > - if (ah->ah_version == AR5K_AR5212 && > - op_mode != NL80211_IFTYPE_AP) > - ath5k_hw_set_sleep_clock(ah, true); > - > /* > * Disable beacons and reset the TSF > */ > -- > 1.7.3.2 > a) LegacyHAL and Sam's HAL both enable it b) Not many cards have a 32KHz crystal anyway (disabled on EEPROM) c) Please don't just remove code, if you want to disable it you can always comment it out d) Why not make it a module parameter instead ? -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 7/8] ath5k: disable 32KHz sleep clock operation 2011-07-04 9:58 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Nick Kossifidis @ 2011-07-04 10:07 ` Felix Fietkau 2011-07-04 10:14 ` Nick Kossifidis 0 siblings, 1 reply; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 10:07 UTC (permalink / raw) To: Nick Kossifidis; +Cc: linux-wireless, linville, ath5k-devel On 2011-07-04 4:58 PM, Nick Kossifidis wrote: > 2011/7/4 Felix Fietkau<nbd@openwrt.org>: >> While 32 KHz sleep clock might provide some power saving benefits, >> it is also a major source of stability issues, on OpenWrt it produced >> some reproducible data bus errors on register accesses on several >> different MIPS platforms. >> >> All the Atheros drivers that I can find do not enable this feature, >> so it makes sense to leave it disabled in ath5k as well. >> >> Signed-off-by: Felix Fietkau<nbd@openwrt.org> >> --- >> drivers/net/wireless/ath/ath5k/reset.c | 9 --------- >> 1 files changed, 0 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c >> index 55276ce..192c0cb 100644 >> --- a/drivers/net/wireless/ath/ath5k/reset.c >> +++ b/drivers/net/wireless/ath/ath5k/reset.c >> @@ -1285,15 +1285,6 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode, >> */ >> ath5k_hw_dma_init(ah); >> >> - >> - /* Enable 32KHz clock function for AR5212+ chips >> - * Set clocks to 32KHz operation and use an >> - * external 32KHz crystal when sleeping if one >> - * exists */ >> - if (ah->ah_version == AR5K_AR5212&& >> - op_mode != NL80211_IFTYPE_AP) >> - ath5k_hw_set_sleep_clock(ah, true); >> - >> /* >> * Disable beacons and reset the TSF >> */ >> -- >> 1.7.3.2 >> > > a) LegacyHAL and Sam's HAL both enable it At least in the Legacy HAL (and in all other HALs that I looked a) I found this in the attach function: ahp->ah_enable32kHzClock = DONT_USE_32KHZ;/* XXX */ > b) Not many cards have a 32KHz crystal anyway (disabled on EEPROM) > c) Please don't just remove code, if you want to disable it you can > always comment it out OK. > d) Why not make it a module parameter instead ? I'm not sure 32 KHz has been tested properly and found to be stable anywhere, so I'm not convinced it will be useful to anybody. Also, I think a debugfs parameter might be better because then it can be enabled/disabled per card. - Felix ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 7/8] ath5k: disable 32KHz sleep clock operation 2011-07-04 10:07 ` Felix Fietkau @ 2011-07-04 10:14 ` Nick Kossifidis 2011-07-04 14:41 ` Kalle Valo 0 siblings, 1 reply; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 10:14 UTC (permalink / raw) To: Felix Fietkau; +Cc: linux-wireless, linville, ath5k-devel 2011/7/4 Felix Fietkau <nbd@openwrt.org>: > On 2011-07-04 4:58 PM, Nick Kossifidis wrote: >> >> 2011/7/4 Felix Fietkau<nbd@openwrt.org>: >>> >>> While 32 KHz sleep clock might provide some power saving benefits, >>> it is also a major source of stability issues, on OpenWrt it produced >>> some reproducible data bus errors on register accesses on several >>> different MIPS platforms. >>> >>> All the Atheros drivers that I can find do not enable this feature, >>> so it makes sense to leave it disabled in ath5k as well. >>> >>> Signed-off-by: Felix Fietkau<nbd@openwrt.org> >>> --- >>> drivers/net/wireless/ath/ath5k/reset.c | 9 --------- >>> 1 files changed, 0 insertions(+), 9 deletions(-) >>> >>> diff --git a/drivers/net/wireless/ath/ath5k/reset.c >>> b/drivers/net/wireless/ath/ath5k/reset.c >>> index 55276ce..192c0cb 100644 >>> --- a/drivers/net/wireless/ath/ath5k/reset.c >>> +++ b/drivers/net/wireless/ath/ath5k/reset.c >>> @@ -1285,15 +1285,6 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum >>> nl80211_iftype op_mode, >>> */ >>> ath5k_hw_dma_init(ah); >>> >>> - >>> - /* Enable 32KHz clock function for AR5212+ chips >>> - * Set clocks to 32KHz operation and use an >>> - * external 32KHz crystal when sleeping if one >>> - * exists */ >>> - if (ah->ah_version == AR5K_AR5212&& >>> - op_mode != NL80211_IFTYPE_AP) >>> - ath5k_hw_set_sleep_clock(ah, true); >>> - >>> /* >>> * Disable beacons and reset the TSF >>> */ >>> -- >>> 1.7.3.2 >>> >> >> a) LegacyHAL and Sam's HAL both enable it > > At least in the Legacy HAL (and in all other HALs that I looked a) I found > this in the attach function: > ahp->ah_enable32kHzClock = DONT_USE_32KHZ;/* XXX */ > Ouch, I missed that part... >> b) Not many cards have a 32KHz crystal anyway (disabled on EEPROM) >> c) Please don't just remove code, if you want to disable it you can >> always comment it out > > OK. > >> d) Why not make it a module parameter instead ? > > I'm not sure 32 KHz has been tested properly and found to be stable > anywhere, so I'm not convinced it will be useful to anybody. Also, I think a > debugfs parameter might be better because then it can be enabled/disabled > per card. > > - Felix > O.K. let's comment it out then and add some information that it's disabled by default on available HALs... -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 7/8] ath5k: disable 32KHz sleep clock operation 2011-07-04 10:14 ` Nick Kossifidis @ 2011-07-04 14:41 ` Kalle Valo 2011-07-04 21:02 ` Nick Kossifidis 0 siblings, 1 reply; 21+ messages in thread From: Kalle Valo @ 2011-07-04 14:41 UTC (permalink / raw) To: Nick Kossifidis; +Cc: Felix Fietkau, linux-wireless, linville, ath5k-devel Nick Kossifidis <mickflemm@gmail.com> writes: > O.K. let's comment it out then and add some information that it's > disabled by default on available HALs... Leaving dead code lying around is bad. Why not add a comment with some pointers how to get the old code if someone wants to do that? For example git commit id is a good reference and I'm sure it will work even after 10 years. -- Kalle Valo ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 7/8] ath5k: disable 32KHz sleep clock operation 2011-07-04 14:41 ` Kalle Valo @ 2011-07-04 21:02 ` Nick Kossifidis 0 siblings, 0 replies; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 21:02 UTC (permalink / raw) To: Kalle Valo; +Cc: Felix Fietkau, linux-wireless, linville, ath5k-devel 2011/7/4 Kalle Valo <kvalo@adurom.com>: > Nick Kossifidis <mickflemm@gmail.com> writes: > >> O.K. let's comment it out then and add some information that it's >> disabled by default on available HALs... > > Leaving dead code lying around is bad. Why not add a comment with some > pointers how to get the old code if someone wants to do that? For > example git commit id is a good reference and I'm sure it will work > even after 10 years. > OK but either we remove the whole thing (ath5k_hw_set_sleep_cloc also, it's not being called anywhere else) or go the other way and leave it there with a comment or a debugfs/modparam. I believe having it as a debugfs/modparam option is better, after all it worked so far for most cards, we didn't had any bug reports related to 32KHz operation (at least I don't remember any). -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 6/8] ath5k: fix reference clock usec duration setting restore 2011-07-04 5:47 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Felix Fietkau 2011-07-04 5:47 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Felix Fietkau @ 2011-07-04 10:25 ` Nick Kossifidis 1 sibling, 0 replies; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 10:25 UTC (permalink / raw) To: Felix Fietkau; +Cc: linux-wireless, linville, ath5k-devel 2011/7/4 Felix Fietkau <nbd@openwrt.org>: > enabling the sleep clock alters the AR5K_USEC_32 field, but disabling > it didn't restore it. > > Signed-off-by: Felix Fietkau <nbd@openwrt.org> > --- > drivers/net/wireless/ath/ath5k/reset.c | 11 ++++++++++- > 1 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c > index 1676a3e..55276ce 100644 > --- a/drivers/net/wireless/ath/ath5k/reset.c > +++ b/drivers/net/wireless/ath/ath5k/reset.c > @@ -233,7 +233,7 @@ static void ath5k_hw_init_core_clock(struct ath5k_hw *ah) > static void ath5k_hw_set_sleep_clock(struct ath5k_hw *ah, bool enable) > { > struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom; > - u32 scal, spending; > + u32 scal, spending, sclock; > > /* Only set 32KHz settings if we have an external > * 32KHz crystal present */ > @@ -317,6 +317,15 @@ static void ath5k_hw_set_sleep_clock(struct ath5k_hw *ah, bool enable) > > /* Set up tsf increment on each cycle */ > AR5K_REG_WRITE_BITS(ah, AR5K_TSF_PARM, AR5K_TSF_PARM_INC, 1); > + > + if ((ah->ah_radio == AR5K_RF5112) || > + (ah->ah_radio == AR5K_RF5413) || > + (ah->ah_radio == AR5K_RF2316) || > + (ah->ah_radio == AR5K_RF2317)) > + sclock = 40 - 1; > + else > + sclock = 32 - 1; > + AR5K_REG_WRITE_BITS(ah, AR5K_USEC_5211, AR5K_USEC_32, sclock); > } > } > > -- > 1.7.3.2 > Acked-by: Nick Kossifidis <mickflemm@gmail.com> -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [ath5k-devel] [PATCH 5/8] ath5k: delay full calibration after reset 2011-07-04 5:47 ` [PATCH 5/8] ath5k: delay full calibration after reset Felix Fietkau 2011-07-04 5:47 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Felix Fietkau @ 2011-07-04 10:34 ` Nick Kossifidis 1 sibling, 0 replies; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 10:34 UTC (permalink / raw) To: Felix Fietkau; +Cc: linux-wireless, ath5k-devel, linville 2011/7/4 Felix Fietkau <nbd@openwrt.org>: > During scans the full calibration usually does not make much sense, > PAPD probing and IQ calibration should be deferred until there is > enough time to complete them. Adding 100 ms to the initial full > calibration delay should be enough to do this. > > Signed-off-by: Felix Fietkau <nbd@openwrt.org> > --- > drivers/net/wireless/ath/ath5k/base.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c > index a413aa7..efec14f 100644 > --- a/drivers/net/wireless/ath/ath5k/base.c > +++ b/drivers/net/wireless/ath/ath5k/base.c > @@ -2728,7 +2728,7 @@ ath5k_reset(struct ath5k_softc *sc, struct ieee80211_channel *chan, > > ath5k_ani_init(ah, ani_mode); > > - ah->ah_cal_next_full = jiffies; > + ah->ah_cal_next_full = jiffies + msecs_to_jiffies(100); > ah->ah_cal_next_ani = jiffies; > ah->ah_cal_next_nf = jiffies; > ewma_init(&ah->ah_beacon_rssi_avg, 1024, 8); > -- > 1.7.3.2 > BTW have you checked this one -> http://www.kernel.org/pub/linux/kernel/people/mickflemm/calibtest.patch ? Acked-by: Nick Kossifidis <mickflemm@gmail.com> -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate [not found] ` <1309758467-1712-4-git-send-email-nbd@openwrt.org> 2011-07-04 5:47 ` [PATCH 5/8] ath5k: delay full calibration after reset Felix Fietkau @ 2011-07-04 10:40 ` Nick Kossifidis 2011-07-04 10:44 ` Felix Fietkau 1 sibling, 1 reply; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 10:40 UTC (permalink / raw) To: Felix Fietkau; +Cc: linux-wireless, ath5k-devel, linville 2011/7/4 Felix Fietkau <nbd@openwrt.org>: > Fixes a division by zero when setting distance before activating the > device for the first time. > > Signed-off-by: Felix Fietkau <nbd@openwrt.org> > --- > drivers/net/wireless/ath/ath5k/base.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c > index a6623dd..a413aa7 100644 > --- a/drivers/net/wireless/ath/ath5k/base.c > +++ b/drivers/net/wireless/ath/ath5k/base.c > @@ -2422,6 +2422,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const struct ath_bus_ops *bus_ops) > common->ah = sc->ah; > common->hw = hw; > common->priv = sc; > + common->clockrate = 40; > > /* > * Cache line size is used to size and align various > -- > 1.7.3.2 > We better set this to 44 for g (according to docs core frequency is 44MHz for g) -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate 2011-07-04 10:40 ` [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate Nick Kossifidis @ 2011-07-04 10:44 ` Felix Fietkau 2011-07-04 10:49 ` Nick Kossifidis 0 siblings, 1 reply; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 10:44 UTC (permalink / raw) To: Nick Kossifidis; +Cc: linux-wireless, ath5k-devel, linville On 2011-07-04 5:40 PM, Nick Kossifidis wrote: > 2011/7/4 Felix Fietkau<nbd@openwrt.org>: >> Fixes a division by zero when setting distance before activating the >> device for the first time. >> >> Signed-off-by: Felix Fietkau<nbd@openwrt.org> >> --- >> drivers/net/wireless/ath/ath5k/base.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c >> index a6623dd..a413aa7 100644 >> --- a/drivers/net/wireless/ath/ath5k/base.c >> +++ b/drivers/net/wireless/ath/ath5k/base.c >> @@ -2422,6 +2422,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const struct ath_bus_ops *bus_ops) >> common->ah = sc->ah; >> common->hw = hw; >> common->priv = sc; >> + common->clockrate = 40; >> >> /* >> * Cache line size is used to size and align various >> -- >> 1.7.3.2 >> > > We better set this to 44 for g (according to docs core frequency is 44MHz for g) It shouldn't make a difference, since the first hardware reset will reload all the settings anyway. - Felix ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate 2011-07-04 10:44 ` Felix Fietkau @ 2011-07-04 10:49 ` Nick Kossifidis 0 siblings, 0 replies; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 10:49 UTC (permalink / raw) To: Felix Fietkau; +Cc: linux-wireless, ath5k-devel, linville 2011/7/4 Felix Fietkau <nbd@openwrt.org>: > On 2011-07-04 5:40 PM, Nick Kossifidis wrote: >> >> 2011/7/4 Felix Fietkau<nbd@openwrt.org>: >>> >>> Fixes a division by zero when setting distance before activating the >>> device for the first time. >>> >>> Signed-off-by: Felix Fietkau<nbd@openwrt.org> >>> --- >>> drivers/net/wireless/ath/ath5k/base.c | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/net/wireless/ath/ath5k/base.c >>> b/drivers/net/wireless/ath/ath5k/base.c >>> index a6623dd..a413aa7 100644 >>> --- a/drivers/net/wireless/ath/ath5k/base.c >>> +++ b/drivers/net/wireless/ath/ath5k/base.c >>> @@ -2422,6 +2422,7 @@ ath5k_init_softc(struct ath5k_softc *sc, const >>> struct ath_bus_ops *bus_ops) >>> common->ah = sc->ah; >>> common->hw = hw; >>> common->priv = sc; >>> + common->clockrate = 40; >>> >>> /* >>> * Cache line size is used to size and align various >>> -- >>> 1.7.3.2 >>> >> >> We better set this to 44 for g (according to docs core frequency is 44MHz >> for g) > > It shouldn't make a difference, since the first hardware reset will reload > all the settings anyway. > > - Felix > O.K. Acked-by: Nick Kossifidis <mickflemm@gmail.com> -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 2011-07-04 5:47 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Felix Fietkau [not found] ` <1309758467-1712-4-git-send-email-nbd@openwrt.org> @ 2011-07-04 10:27 ` Nick Kossifidis 1 sibling, 0 replies; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 10:27 UTC (permalink / raw) To: Felix Fietkau; +Cc: linux-wireless, linville, ath5k-devel 2011/7/4 Felix Fietkau <nbd@openwrt.org>: > AR2413 uses the same reference clock as AR5413 > > Signed-off-by: Felix Fietkau <nbd@openwrt.org> > --- > drivers/net/wireless/ath/ath5k/phy.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c > index f66124a..c65c33a 100644 > --- a/drivers/net/wireless/ath/ath5k/phy.c > +++ b/drivers/net/wireless/ath/ath5k/phy.c > @@ -105,6 +105,7 @@ bool ath5k_hw_chan_has_spur_noise(struct ath5k_hw *ah, > > if ((ah->ah_radio == AR5K_RF5112) || > (ah->ah_radio == AR5K_RF5413) || > + (ah->ah_radio == AR5K_RF2413) || > (ah->ah_mac_version == (AR5K_SREV_AR2417 >> 4))) > refclk_freq = 40; > else > -- > 1.7.3.2 > If that's true we should also change it on set_sleep_clock (patch 6 on your series). -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [ath5k-devel] [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 2011-07-04 5:47 ` [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Felix Fietkau 2011-07-04 5:47 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Felix Fietkau @ 2011-07-04 10:29 ` Nick Kossifidis 1 sibling, 0 replies; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 10:29 UTC (permalink / raw) To: Felix Fietkau; +Cc: linux-wireless, ath5k-devel, linville MjAxMS83LzQgRmVsaXggRmlldGthdSA8bmJkQG9wZW53cnQub3JnPjoKPiBNaWdodCBmaXggc29t ZSBzdGFiaWxpdHkgaXNzdWVzIG9uIG5ld2VyIGNoaXBzCj4KPiBTaWduZWQtb2ZmLWJ5OiBGZWxp eCBGaWV0a2F1IDxuYmRAb3BlbndydC5vcmc+Cj4gLS0tCj4gwqBkcml2ZXJzL25ldC93aXJlbGVz cy9hdGgvYXRoNWsvcGh5LmMgfCDCoCAxOSArKysrKysrKysrKy0tLS0tLS0tCj4gwqAxIGZpbGVz IGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL2F0aDVrL3BoeS5jIGIvZHJpdmVycy9uZXQvd2ly ZWxlc3MvYXRoL2F0aDVrL3BoeS5jCj4gaW5kZXggYzc3NDQ2OC4uZjY2MTI0YSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9hdGgvYXRoNWsvcGh5LmMKPiArKysgYi9kcml2ZXJz L25ldC93aXJlbGVzcy9hdGgvYXRoNWsvcGh5LmMKPiBAQCAtOTcwLDE3ICs5NzAsMjAgQEAgc3Rh dGljIGludCBhdGg1a19od19yZnJlZ3NfaW5pdChzdHJ1Y3QgYXRoNWtfaHcgKmFoLAo+IMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgfQo+Cj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAvKiBMb3dlciBzeW50aCB2b2x0YWdlIG9uIFJldiAyICovCj4gLSDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBhdGg1a19od19yZmJfb3AoYWgsIHJmX3JlZ3Ms IDIsCj4gLSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCBBUjVLX1JGX0hJR0hfVkNfQ1AsIHRydWUpOwo+ICsgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgaWYgKGFoLT5haF9yYWRpbyA9PSBBUjVLX1JGNTExMiAmJgo+ICsgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgKGFoLT5haF9yYWRpb181Z2h6X3Jl dmlzaW9uICYgQVI1S19TUkVWX1JFVikgPiAwKSB7Cj4gKyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBhdGg1a19od19yZmJfb3AoYWgsIHJmX3JlZ3MsIDIsCj4g KyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCBBUjVLX1JGX0hJR0hfVkNfQ1AsIHRydWUpOwo+Cj4gLSDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBhdGg1a19od19yZmJfb3AoYWgsIHJmX3JlZ3MsIDIsCj4g LSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCBBUjVLX1JGX01JRF9WQ19DUCwgdHJ1ZSk7Cj4gKyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCBhdGg1a19od19yZmJfb3AoYWgsIHJmX3JlZ3MsIDIsCj4gKyDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCBBUjVLX1JGX01JRF9WQ19DUCwgdHJ1ZSk7Cj4KPiAtIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIGF0aDVrX2h3X3JmYl9vcChhaCwgcmZfcmVncywgMiwKPiAtIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIEFS NUtfUkZfTE9XX1ZDX0NQLCB0cnVlKTsKPiArIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIGF0aDVrX2h3X3JmYl9vcChhaCwgcmZfcmVncywgMiwKPiArIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIEFSNUtfUkZfTE9XX1ZDX0NQLCB0cnVlKTsKPgo+IC0gwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgYXRoNWtfaHdfcmZiX29wKGFoLCByZl9yZWdzLCAyLAo+IC0gwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgQVI1S19S Rl9QVVNIX1VQLCB0cnVlKTsKPiArIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIGF0aDVrX2h3X3JmYl9vcChhaCwgcmZfcmVncywgMiwKPiArIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IEFSNUtfUkZfUFVTSF9VUCwgdHJ1ZSk7Cj4gKyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCB9Cj4KPiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoC8qIERlY3JlYXNl IHBvd2VyIGNvbnN1bXB0aW9uIG9uIDUyMTMrIEJhc2VCYW5kICovCj4gwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqBpZiAoYWgtPmFoX3BoeV9yZXZpc2lvbiA+PSBBUjVLX1NSRVZf UEhZXzUyMTJBKSB7CgpBY2tlZC1ieTogTmljayBLb3NzaWZpZGlzIDxtaWNrZmxlbW1AZ21haWwu Y29tPgoKCi0tIApHUEcgSUQ6IDB4RDIxREIyREIKQXMgeW91IHJlYWQgdGhpcyBwb3N0IGdsb2Jh bCBlbnRyb3B5IHJpc2VzLiBIYXZlIEZ1biA7LSkKTmljawo= ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] ath5k: add missing checks for rfgain probe 2011-07-04 5:47 [PATCH 1/8] ath5k: add missing checks for rfgain probe Felix Fietkau 2011-07-04 5:47 ` [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Felix Fietkau @ 2011-07-04 9:48 ` Nick Kossifidis 2011-07-04 9:56 ` Felix Fietkau 1 sibling, 1 reply; 21+ messages in thread From: Nick Kossifidis @ 2011-07-04 9:48 UTC (permalink / raw) To: Felix Fietkau; +Cc: linux-wireless, linville, ath5k-devel 2011/7/4 Felix Fietkau <nbd@openwrt.org>: > rfgain probe is only necessary for OFDM operation on AR5112 and no other > radio chips > It's also available on RF5111 (with AR5211 or AR5212)... -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/8] ath5k: add missing checks for rfgain probe 2011-07-04 9:48 ` [PATCH 1/8] ath5k: add missing checks for rfgain probe Nick Kossifidis @ 2011-07-04 9:56 ` Felix Fietkau 0 siblings, 0 replies; 21+ messages in thread From: Felix Fietkau @ 2011-07-04 9:56 UTC (permalink / raw) To: Nick Kossifidis; +Cc: linux-wireless, linville, ath5k-devel On 2011-07-04 4:48 PM, Nick Kossifidis wrote: > 2011/7/4 Felix Fietkau<nbd@openwrt.org>: >> rfgain probe is only necessary for OFDM operation on AR5112 and no other >> radio chips >> > > It's also available on RF5111 (with AR5211 or AR5212)... Oh, right, missed that. Will send a v2. - Felix ^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2011-07-04 21:02 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-04 5:47 [PATCH 1/8] ath5k: add missing checks for rfgain probe Felix Fietkau
2011-07-04 5:47 ` [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Felix Fietkau
2011-07-04 5:47 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Felix Fietkau
[not found] ` <1309758467-1712-4-git-send-email-nbd@openwrt.org>
2011-07-04 5:47 ` [PATCH 5/8] ath5k: delay full calibration after reset Felix Fietkau
2011-07-04 5:47 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Felix Fietkau
2011-07-04 5:47 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Felix Fietkau
2011-07-04 5:47 ` [PATCH 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211 Felix Fietkau
2011-07-04 9:58 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Nick Kossifidis
2011-07-04 10:07 ` Felix Fietkau
2011-07-04 10:14 ` Nick Kossifidis
2011-07-04 14:41 ` Kalle Valo
2011-07-04 21:02 ` Nick Kossifidis
2011-07-04 10:25 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Nick Kossifidis
2011-07-04 10:34 ` [ath5k-devel] [PATCH 5/8] ath5k: delay full calibration after reset Nick Kossifidis
2011-07-04 10:40 ` [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate Nick Kossifidis
2011-07-04 10:44 ` Felix Fietkau
2011-07-04 10:49 ` Nick Kossifidis
2011-07-04 10:27 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Nick Kossifidis
2011-07-04 10:29 ` [ath5k-devel] [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Nick Kossifidis
2011-07-04 9:48 ` [PATCH 1/8] ath5k: add missing checks for rfgain probe Nick Kossifidis
2011-07-04 9:56 ` Felix Fietkau
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).