From: Felix Fietkau <nbd@openwrt.org>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH 7/8] ath5k: disable 32KHz sleep clock operation
Date: Mon, 04 Jul 2011 17:07:59 +0700 [thread overview]
Message-ID: <4E1190FF.9010701@openwrt.org> (raw)
In-Reply-To: <CAFtRNNyPJOtjW8vDnjveqmMD3snt_iaDV45p3QZEOKrSyED3yg@mail.gmail.com>
On 2011-07-04 4:58 PM, Nick Kossifidis wrote:
> 2011/7/4 Felix Fietkau<nbd@openwrt.org>:
>> While 32 KHz sleep clock might provide some power saving benefits,
>> it is also a major source of stability issues, on OpenWrt it produced
>> some reproducible data bus errors on register accesses on several
>> different MIPS platforms.
>>
>> All the Atheros drivers that I can find do not enable this feature,
>> so it makes sense to leave it disabled in ath5k as well.
>>
>> Signed-off-by: Felix Fietkau<nbd@openwrt.org>
>> ---
>> drivers/net/wireless/ath/ath5k/reset.c | 9 ---------
>> 1 files changed, 0 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath5k/reset.c b/drivers/net/wireless/ath/ath5k/reset.c
>> index 55276ce..192c0cb 100644
>> --- a/drivers/net/wireless/ath/ath5k/reset.c
>> +++ b/drivers/net/wireless/ath/ath5k/reset.c
>> @@ -1285,15 +1285,6 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode,
>> */
>> ath5k_hw_dma_init(ah);
>>
>> -
>> - /* Enable 32KHz clock function for AR5212+ chips
>> - * Set clocks to 32KHz operation and use an
>> - * external 32KHz crystal when sleeping if one
>> - * exists */
>> - if (ah->ah_version == AR5K_AR5212&&
>> - op_mode != NL80211_IFTYPE_AP)
>> - ath5k_hw_set_sleep_clock(ah, true);
>> -
>> /*
>> * Disable beacons and reset the TSF
>> */
>> --
>> 1.7.3.2
>>
>
> a) LegacyHAL and Sam's HAL both enable it
At least in the Legacy HAL (and in all other HALs that I looked a) I
found this in the attach function:
ahp->ah_enable32kHzClock = DONT_USE_32KHZ;/* XXX */
> b) Not many cards have a 32KHz crystal anyway (disabled on EEPROM)
> c) Please don't just remove code, if you want to disable it you can
> always comment it out
OK.
> d) Why not make it a module parameter instead ?
I'm not sure 32 KHz has been tested properly and found to be stable
anywhere, so I'm not convinced it will be useful to anybody. Also, I
think a debugfs parameter might be better because then it can be
enabled/disabled per card.
- Felix
next prev parent reply other threads:[~2011-07-04 10:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 5:47 [PATCH 1/8] ath5k: add missing checks for rfgain probe Felix Fietkau
2011-07-04 5:47 ` [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Felix Fietkau
2011-07-04 5:47 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Felix Fietkau
[not found] ` <1309758467-1712-4-git-send-email-nbd@openwrt.org>
2011-07-04 5:47 ` [PATCH 5/8] ath5k: delay full calibration after reset Felix Fietkau
2011-07-04 5:47 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Felix Fietkau
2011-07-04 5:47 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Felix Fietkau
2011-07-04 5:47 ` [PATCH 8/8] ath5k: do not call ieee80211_stop_queue for queues not managed by mac80211 Felix Fietkau
2011-07-04 9:58 ` [PATCH 7/8] ath5k: disable 32KHz sleep clock operation Nick Kossifidis
2011-07-04 10:07 ` Felix Fietkau [this message]
2011-07-04 10:14 ` Nick Kossifidis
2011-07-04 14:41 ` Kalle Valo
2011-07-04 21:02 ` Nick Kossifidis
2011-07-04 10:25 ` [PATCH 6/8] ath5k: fix reference clock usec duration setting restore Nick Kossifidis
2011-07-04 10:34 ` [ath5k-devel] [PATCH 5/8] ath5k: delay full calibration after reset Nick Kossifidis
2011-07-04 10:40 ` [ath5k-devel] [PATCH 4/8] ath5k: initialize common->clockrate Nick Kossifidis
2011-07-04 10:44 ` Felix Fietkau
2011-07-04 10:49 ` Nick Kossifidis
2011-07-04 10:27 ` [PATCH 3/8] ath5k: fix reference clock frequency for spur mitigation on AR2413 Nick Kossifidis
2011-07-04 10:29 ` [ath5k-devel] [PATCH 2/8] ath5k: apply the synth voltage tweak only on AR5112 rev 2 Nick Kossifidis
2011-07-04 9:48 ` [PATCH 1/8] ath5k: add missing checks for rfgain probe Nick Kossifidis
2011-07-04 9:56 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1190FF.9010701@openwrt.org \
--to=nbd@openwrt.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).