From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH 3.0] ssb: fix init regression of hostmode PCI core
Date: Wed, 06 Jul 2011 20:53:43 +0200 [thread overview]
Message-ID: <4E14AF37.8050000@hauke-m.de> (raw)
In-Reply-To: <1309879532-8704-1-git-send-email-zajec5@gmail.com>
On 07/05/2011 05:25 PM, Rafał Miłecki wrote:
> Our workarounds seem to be clientmode PCI specific. Using SPROM
> workaround on SoC resulted in Oops:
>
> Data bus error, epc == 8017ed58, ra == 80225838
> Oops[#1]:
> Cpu 0
> $ 0 : 00000000 10008000 b8000000 00000001
> $ 4 : 80293b5c 00000caa ffffffff 00000000
> $ 8 : 0000000a 00000003 00000001 696d6d20
> $12 : ffffffff 00000000 00000000 ffffffff
> $16 : 802d0140 b8004800 802c0000 00000000
> $20 : 00000000 802c0000 00000000 802d04d4
> $24 : 00000018 80151a00
> $28 : 81816000 81817df8 8029bda0 80225838
> Hi : 00000000
> Lo : 00000000
> epc : 8017ed58 ssb_ssb_read16+0x48/0x60
> Not tainted
> ra : 80225838 ssb_pcicore_init+0x54/0x3b4
>
> Reported-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> Hauke: could you give it a try?
After applying this patch I do not get this Data bus error any more.
>
> John: this regression was introduced in 3.0
> ---
> drivers/ssb/driver_pcicore.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/ssb/driver_pcicore.c b/drivers/ssb/driver_pcicore.c
> index 21b9465..11d85bf 100644
> --- a/drivers/ssb/driver_pcicore.c
> +++ b/drivers/ssb/driver_pcicore.c
> @@ -516,8 +516,17 @@ static void ssb_pcicore_pcie_setup_workarounds(struct ssb_pcicore *pc)
>
> static void __devinit ssb_pcicore_init_clientmode(struct ssb_pcicore *pc)
> {
> + ssb_pcicore_fix_sprom_core_index(pc);
> +
> /* Disable PCI interrupts. */
> ssb_write32(pc->dev, SSB_INTVEC, 0);
> +
> + /* Additional PCIe always once-executed workarounds */
> + if (pc->dev->id.coreid == SSB_DEV_PCIE) {
> + ssb_pcicore_serdes_workaround(pc);
> + /* TODO: ASPM */
> + /* TODO: Clock Request Update */
> + }
> }
>
> void __devinit ssb_pcicore_init(struct ssb_pcicore *pc)
> @@ -529,8 +538,6 @@ void __devinit ssb_pcicore_init(struct ssb_pcicore *pc)
> if (!ssb_device_is_enabled(dev))
> ssb_device_enable(dev, 0);
>
> - ssb_pcicore_fix_sprom_core_index(pc);
> -
> #ifdef CONFIG_SSB_PCICORE_HOSTMODE
> pc->hostmode = pcicore_is_in_hostmode(pc);
> if (pc->hostmode)
> @@ -538,13 +545,6 @@ void __devinit ssb_pcicore_init(struct ssb_pcicore *pc)
> #endif /* CONFIG_SSB_PCICORE_HOSTMODE */
> if (!pc->hostmode)
> ssb_pcicore_init_clientmode(pc);
> -
> - /* Additional PCIe always once-executed workarounds */
> - if (dev->id.coreid == SSB_DEV_PCIE) {
> - ssb_pcicore_serdes_workaround(pc);
> - /* TODO: ASPM */
> - /* TODO: Clock Request Update */
> - }
> }
>
> static u32 ssb_pcie_read(struct ssb_pcicore *pc, u32 address)
prev parent reply other threads:[~2011-07-06 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 15:25 [PATCH 3.0] ssb: fix init regression of hostmode PCI core Rafał Miłecki
2011-07-06 18:37 ` John W. Linville
2011-07-06 18:53 ` Hauke Mehrtens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E14AF37.8050000@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).