From: Felix Fietkau <nbd@openwrt.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netdev@vger.kernel.org,
Christian Lamparter <chunkeey@googlemail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 04/46] net/wireless: p54: remove useless dma_sync_single_for_device(DMA_FROM_DEVICE)
Date: Tue, 12 Jul 2011 12:50:20 +0800 [thread overview]
Message-ID: <4E1BD28C.2070704@openwrt.org> (raw)
In-Reply-To: <86c8bde08b005ca7eb4806ea77aec1f3212d63fc.1310339688.git.mirq-linux@rere.qmqm.pl>
On 2011-07-11 8:52 AM, Michał Mirosław wrote:
> Also constify pointers used in frame parsers to verify assumptions.
>
> Signed-off-by: Michał Mirosław<mirq-linux@rere.qmqm.pl>
> ---
> drivers/net/wireless/p54/p54pci.c | 2 --
> drivers/net/wireless/p54/txrx.c | 22 +++++++++++-----------
> 2 files changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/wireless/p54/p54pci.c b/drivers/net/wireless/p54/p54pci.c
> index 1b75317..4491d33 100644
> --- a/drivers/net/wireless/p54/p54pci.c
> +++ b/drivers/net/wireless/p54/p54pci.c
> @@ -229,8 +229,6 @@ static void p54p_check_rx_ring(struct ieee80211_hw *dev, u32 *index,
> desc->host_addr = cpu_to_le32(0);
> } else {
> skb_trim(skb, 0);
> - pci_dma_sync_single_for_device(priv->pdev, dma_addr,
> - priv->common.rx_mtu + 32, PCI_DMA_FROMDEVICE);
> desc->len = cpu_to_le16(priv->common.rx_mtu + 32);
> }
>
This part does not look correct to me - same issue as your ath9k change,
which I commented on earlier. I don't think this call to
dma_sync_single_for_device is useless
- Felix
next prev parent reply other threads:[~2011-07-12 4:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1310339688.git.mirq-linux@rere.qmqm.pl>
2011-07-11 0:52 ` [PATCH v2 04/46] net/wireless: p54: remove useless dma_sync_single_for_device(DMA_FROM_DEVICE) Michał Mirosław
2011-07-11 15:15 ` Pavel Roskin
2011-07-12 4:50 ` Felix Fietkau [this message]
2011-07-11 0:52 ` [PATCH v2 08/46] net/wireless: b43: fix DMA direction for RX buffers Michał Mirosław
2011-07-11 0:52 ` [PATCH v2 07/46] net/wireless: ath9k: fix DMA API usage Michał Mirosław
2011-07-12 4:36 ` [ath9k-devel] " Felix Fietkau
2011-07-12 5:30 ` Ben Greear
2011-07-12 9:55 ` Michał Mirosław
2011-07-12 12:54 ` Felix Fietkau
2011-07-12 13:03 ` Michał Mirosław
2011-07-12 14:21 ` Felix Fietkau
2011-07-12 15:58 ` Michał Mirosław
2011-07-12 16:04 ` Felix Fietkau
2011-07-12 19:13 ` Michał Mirosław
2011-07-12 19:32 ` Ralf Baechle
2011-07-12 20:53 ` Michał Mirosław
2011-07-12 20:59 ` Michał Mirosław
2011-07-11 0:52 ` [PATCH v2 15/46] net/wireless: b43: use kfree_skb() for untouched skbs Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1BD28C.2070704@openwrt.org \
--to=nbd@openwrt.org \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).