From: Pavel Roskin <proski@gnu.org>
To: Kalle Valo <kvalo@adurom.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [TODO] at76c50x: remove wext includes
Date: Wed, 13 Jul 2011 09:54:40 -0400 [thread overview]
Message-ID: <4E1DA3A0.1000606@gnu.org> (raw)
In-Reply-To: <4E1D5CB7.7070607@adurom.com>
On 07/13/2011 04:52 AM, Kalle Valo wrote:
> On 07/13/2011 11:47 AM, Johannes Berg wrote:
>> Not possible right now:
>> at76c50x-usb.h:404:11: error: ‘IW_ESSID_MAX_SIZE’ undeclared here (not in a function)
>> at76c50x-usb.c: In function ‘at76_startup_device’:
>> at76c50x-usb.c:1371:263: error: ‘IW_MODE_ADHOC’ undeclared (first use in this function)
>> at76c50x-usb.c:1371:263: note: each undeclared identifier is reported only once for each function it appears in
>> at76c50x-usb.c: In function ‘at76_add_interface’:
>> at76c50x-usb.c:1863:19: error: ‘IW_MODE_INFRA’ undeclared (first use in this function)
>> at76c50x-usb.c: In function ‘at76_init_new_device’:
>> at76c50x-usb.c:2269:18: error: ‘IW_MODE_INFRA’ undeclared (first use in this function)
>>
>> but none of those constants should be used in a mac80211 driver.
>>
>> Also this driver is missing a MAINTAINERS entry.
>
> The driver has been broken due to the mac80211 changes for a long time
> and it's obvious that I can't maintain it anymore as I haven't touched
> it for a long time. I would like to just remove it altogether. Any
> objections?
>
> If someone wants to step up and fix it, now is the time to do it.
Please keep the driver for now! I have a pile of compatible hardware,
and I should be able to fix it. I'm placing it onto my TODO list.
There is some really obsolete hardware that we may need to stop
supporting, e.g. Atheros AR5210, but the reason is because it's
supported by an actively developed driver, ath5k, and the AR5210 code
stands in the way all the time.
However, at76c50x-usb is a separate driver and it doesn't stand in the
way of anybody except when global changes are made.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2011-07-13 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 8:47 [TODO] at76c50x: remove wext includes Johannes Berg
2011-07-13 8:52 ` Kalle Valo
2011-07-13 10:35 ` Julian Calaby
2011-07-13 10:50 ` Kalle Valo
2011-07-13 11:15 ` Julian Calaby
2011-07-13 13:54 ` Pavel Roskin [this message]
2011-07-16 11:41 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1DA3A0.1000606@gnu.org \
--to=proski@gnu.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).